Skip to content
This repository was archived by the owner on Apr 15, 2020. It is now read-only.

Xcode 11, Swift 5.1, release 8.1 prep, +more#132

Merged
jessesquires merged 17 commits into
developfrom
xcode11-swift5-1
Sep 24, 2019
Merged

Xcode 11, Swift 5.1, release 8.1 prep, +more#132
jessesquires merged 17 commits into
developfrom
xcode11-swift5-1

Conversation

@jessesquires
Copy link
Copy Markdown
Owner

@jessesquires jessesquires commented Sep 23, 2019

@jessesquires jessesquires changed the title Xcode 11, Swift 5.1, release 9.0 prep, +more Xcode 11, Swift 5.1, release 8.1 prep, +more Sep 24, 2019
@hal-codebot
Copy link
Copy Markdown

1 Warning
⚠️ This is a large pull request! Can you break it up into multiple smaller ones instead?

Generated by 🚫 Danger

@jessesquires
Copy link
Copy Markdown
Owner Author

ui tests fixed and passing

@jessesquires
Copy link
Copy Markdown
Owner Author

only one UI test failed, test_ThatActionButton_AddNewOption_AddsCell

i think it was a flake, but i'll open a new PR to fix.

@jessesquires jessesquires merged commit ab4470d into develop Sep 24, 2019
@jessesquires jessesquires deleted the xcode11-swift5-1 branch September 24, 2019 23:27
@jessesquires
Copy link
Copy Markdown
Owner Author

test should be fixed in #133

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CocoaPods Migrate to Swift 5

3 participants