Fix the reactivity of the date property#7
Open
fieteboerner wants to merge 4 commits intojillztom:masterfrom
Open
Fix the reactivity of the date property#7fieteboerner wants to merge 4 commits intojillztom:masterfrom
fieteboerner wants to merge 4 commits intojillztom:masterfrom
Conversation
|
👍 |
Closed
ricardobalk
reviewed
Dec 7, 2019
Contributor
ricardobalk
left a comment
ricardobalk
left a comment
There was a problem hiding this comment.
Just added a single line that helps run the code immediately without relying on the first timer occurrence. It's literally one second faster.
Owner
|
@fieteboerner could you fix the conflict and update the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken reactivity to the date-property mentioned in #6.
So now, if the date string changes, the updated value is used for the difference calculation.