Skip to content

Fix the reactivity of the date property #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fieteboerner wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix the reactivity of the date property #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c12b926
Fix the reactivity of the date property
May 10, 2019
57b1d43
execute upateDifferece immediately at creation time
Jan 8, 2020
e54e687
fix indentation
Jan 8, 2020
2a46633
remove unused import
Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions dist/vue-moments-ago.js
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 8 additions & 7 deletions src/components/moments-ago.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
</template>

<script>
import Vue from "vue";
import moment from "moment";
Vue.prototype.moment = moment;

export default {
data() {
Expand Down Expand Up @@ -66,10 +64,13 @@ export default {
}
},

mounted() {
setInterval(() => {
this.getSeconds(this.date);
created() {
this.updateDifference();
const interval = setInterval(() => {
this.updateDifference();
}, 1000);

this.$once('hook:destroyed', () => clearInterval(interval));
},

computed: {
Expand All @@ -95,8 +96,8 @@ export default {
},

methods: {
getSeconds(time) {
let seconds = moment().diff(moment(time), "seconds");
updateDifference() {
let seconds = moment().diff(moment(this.date), "seconds");
this.humanReadable = this.getDuration(seconds);
if (this.humanReadable) {
this.humanDifference = this.humanReadable.interval;
Expand Down