new feature: downloading, reading and deserializing json aws objects#8
Open
jlisok wants to merge 9 commits intochore/content-aws-writerfrom
Open
new feature: downloading, reading and deserializing json aws objects#8jlisok wants to merge 9 commits intochore/content-aws-writerfrom
jlisok wants to merge 9 commits intochore/content-aws-writerfrom
Conversation
mohard
requested changes
Jul 1, 2020
| Content input = cloudObjectContentGetter.getObjectContent(info); | ||
| logger.debug("Transfer Service - extracting content from cloud object - success."); | ||
| DeserializedContent deserializedContent = deserializer.deserialize(input, classToDeserialize); | ||
| logger.debug("Transfer Service - content deserialization - success."); |
| private final Logger logger = LogManager.getLogger(this.getClass()); | ||
|
|
||
| @Override | ||
| public Content deserialize(JsonStorage jsonStorage, Type classTypeToDeserializeJson) throws ContentDeserializationException { |
| // given | ||
| ContentAndStatsStorage<ThreeElemContent> expectedStorage = mockContentAndStatsStorage(new ThreeElemContent(1590147349818750700L, -840762737, "ChristopherRobin")); | ||
| JsonStorage json = serializeContentAndStats(expectedStorage); | ||
| JsonDeserializer<ContentAndStatsStorage<ThreeElemContent>> deserializer = new JsonDeserializer<>(); |
Collaborator
There was a problem hiding this comment.
also try creating a class XXX extends ContentAndStatsStorage
and see if it works with the XXX.class approach
new feature: object uploading on AWS S3 cloud
jlisok
force-pushed
the
feature/read-cloud-content
branch
from
7c3b9b0 to
e9aea44
Compare
mohard
reviewed
Jul 3, 2020
|
|
||
| import java.util.Objects; | ||
|
|
||
| public class ThreeElemContentAndStatsStorage<ContentType> { |
|
|
||
| @Override | ||
| public JsonReadyForJsonWriter convertContent(ContentAndStatsStorage<Content> content) throws ContentConversion2ReadyToWriteException { | ||
| public Json convertContent(ContentAndStats<ContentType> content) throws ContentConversion2ReadyToWriteException { |
should converters return
jlisok
force-pushed
the
feature/read-cloud-content
branch
from
e9aea44 to
5c84ca5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.