Various improvements#134
Closed
whitequark wants to merge 6 commits intojruby:masterfrom
whitequark:master
Closed
Conversation
Member
Author
|
@BanzaiMan, I think you could trivially cherry-pick the commits. In a different case I would fix my PR and resubmit, but as I mostly have no idea how warbler should be written and was just "scratching my own itch", it probably would be faster for you to do it properly. |
Member
|
@whitequark Very well. I'm going to keep this one open, and pick them as I see them fit. When it's done, I'll close it. Again, thanks for your contribution! |
kares
added a commit
to kares/warbler
that referenced
this pull request
Feb 4, 2013
* added notes on executable/runnable feature support (jruby#136) * removed notes on Merb support (JRuby-Rack will remove Merb support completely + it's been most likely non-working in 1.1.x releases anyway) * expect "compiled" .rb to be changed to do a load instead of require - this has been a long incompatibility issue and is present in jruby#134
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sending this after being mentioned in #133 (comment).
Sorry for non-informative pull request title, but this PR is best described by the commit list.
The most important one is definitely https://github.com/whitequark/warbler/commit/04f5f404cb52e961fdac673430e52eeccd1bace1.