Skip to content

java -jar rails.war -S rake db:migrate#136

Merged
BanzaiMan merged 14 commits intomasterfrom
gh-130
Feb 5, 2013
Merged

java -jar rails.war -S rake db:migrate#136
BanzaiMan merged 14 commits intomasterfrom
gh-130

Conversation

@BanzaiMan
Copy link
Member

@BanzaiMan BanzaiMan commented Jan 31, 2013

This pull requests supersedes #130, which was created by @kares.

kares and others added 14 commits December 28, 2012 13:36
@kares
bring warbler's deps somehow (at least fairly) up to-date
e79d38a
@kares
we shall fail without the bundler gem installed
0b06588
@kares
WarMain extends JarMain for code reuse
0d154dd
@kares
more refactoring towards an (almost) working -S rake -T
9ffe2fd
@kares
pass in cli args to processArguments; file: URIs seem to work better
f4b6c0a
@kares
working better when app gets fully extracted
a843c4b
@kares
ENV should be cleared otherwise it might interfere with local ruby in…
b8df918 
…stallation
@kares
actualy avoid ENV.clear and setup GEM_PATH (besides GEM_HOME) instead
49e4eaa
@kares
package db/ dir + include *file-s (e.g. Rakefile) by default
1853d1f 
exclude tmp/cache since it might contain (compiled) assets
@kares
avoid RbConfig warns + rdoctask load error on MRI 1.9.3
64c87f6
@kares
RCov 1.0.0 seems to only compile on MRI 1.8
507dd11
@kares
include a runnable task (executable wihout the web server)
d990414 
this allows to make a war for running packagted binaries such as `rake db:migrate` while not embedding a web server
@kares
provide some explanation for java -jar rails.war (without -S)
509b71c
@BanzaiMan
Merge remote-tracking branch 'kares/runnable' into gh-130
ff10266 
Conflicts:
	.gitignore
	Gemfile
	ext/JarMain.java
	spec/sample_war/Rakefile
@BanzaiMan BanzaiMan mentioned this pull request Jan 31, 2013
Closed
@BanzaiMan
Copy link
Member Author

BanzaiMan commented Feb 1, 2013

The gem is available here: http://db.tt/R1okA4Cm (a Dropbox link).

@kares
Copy link
Member

kares commented Feb 1, 2013

@BanzaiMan great, looking good :shipit: - let me know if there's anything I can help / explain ...
although most of the code is almost a year old now and (has been laying around my local branch)

@BanzaiMan
Copy link
Member Author

BanzaiMan commented Feb 2, 2013

@kares Good to hear. Can we have documentation (README is fine, since we don't have Wiki here)?

kares added a commit to kares/warbler that referenced this pull request Feb 4, 2013
@kares
README review , most importantly :
c1c6950 
* added notes on executable/runnable feature support (jruby#136)
* removed notes on Merb support (JRuby-Rack will remove Merb support completely + it's been most likely non-working in 1.1.x releases anyway)
* expect "compiled" .rb to be changed to do a load instead of require - this has been a long incompatibility issue and is present in jruby#134
@kares kares mentioned this pull request Feb 4, 2013
Merged
BanzaiMan added a commit that referenced this pull request Feb 5, 2013
@BanzaiMan
Merge pull request #136 from jruby/gh-130
ce3ce4d 
java -jar rails.war -S rake db:migrate
@BanzaiMan BanzaiMan merged commit ce3ce4d into master Feb 5, 2013
@bjeanes
Copy link
Contributor

bjeanes commented Mar 4, 2013

Is this supposed to work for non-rake commands? I couldn't get any other gem commands to work, even after bundling with --binstubs and adding bin to the Warbler config's dirs array.

From a cursory glance at the diff, it doesn't seem to be rake-specific, but I can't make sense of how it works either, so looking for some direction.

@bjeanes bjeanes mentioned this pull request Mar 6, 2013
Closed
6 tasks
@bjeanes
Copy link
Contributor

bjeanes commented Mar 8, 2013

I'm now working on a pull request (#141) to improve this functionality and the implementing code in order to make my use case work (successfully running Bundler gem binaries).

@nicksieger Are there tests for the likes of WarMain and JarMain, etc?

@bjeanes bjeanes mentioned this pull request Mar 8, 2013
Merged
@bbozo
Copy link

bbozo commented Mar 13, 2013

Thank you, beautiful people, using @bjeanes branch atm, saved lives

👍

@bjeanes
Copy link
Contributor

bjeanes commented Mar 13, 2013

Awesome! I'm glad my branch is helping you out. If we can get more eyes on #141 maybe it can help others too :)

@richievos richievos mentioned this pull request May 6, 2014
Open
@kares kares deleted the gh-130 branch April 30, 2016 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BanzaiMan @kares @bjeanes @bbozo