-
Notifications
You must be signed in to change notification settings - Fork 103
Closed
Labels
area/nonpythonPull requests that updates non-Python code (bash, Makefile, etc.)Pull requests that updates non-Python code (bash, Makefile, etc.)kind/CIAbout CI infra or testsAbout CI infra or testskind/docindicates a documentation changeindicates a documentation changepriority/normalnormal prioritynormal priority
Description
Description
Current message:
Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.
Link 404s. The 'correct' link would be https://github.com/juju/juju/blob/main/doc/CONTRIBUTING.md, but even then there's a bunch of Juju specific information that doesn't apply here, such as "Bug reports should be filed on Launchpad, not GitHub".
We should link to python-libjuju CONTRIBUTING.md instead, but at the very least that should be updated to explain the juju conventional commits convention, e.g. linking here.
Also it seems to double post? (See here and here).
Also it should probably ping someone else, like @dimaqq and I.
Urgency
Casually reporting
Python-libjuju version
main
Juju version
n/a
Reproduce / Test
...Metadata
Metadata
Assignees
Labels
area/nonpythonPull requests that updates non-Python code (bash, Makefile, etc.)Pull requests that updates non-Python code (bash, Makefile, etc.)kind/CIAbout CI infra or testsAbout CI infra or testskind/docindicates a documentation changeindicates a documentation changepriority/normalnormal prioritynormal priority