Skip to content

Conversation

@dimbleby
Copy link

  • publish wheels as well as sdists
  • direct invocation of setup.py is deprecated these days, prefer build to create those distributions
  • fix the makefile so that it uses the virtual environment that it creates

@jujubot
Copy link
Contributor

jujubot commented Nov 13, 2024

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

1 similar comment
@jujubot
Copy link
Contributor

jujubot commented Nov 13, 2024

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

@dimbleby
Copy link
Author

(you might want to update your bot so that it points to something more useful than 404 not found)

@dimaqq
Copy link
Contributor

dimaqq commented Nov 14, 2024

Thank you @dimbleby

May I ask the context for your request? Are you using this library or is this a generic concern?

P.S. I was going to improve the build and publication process, though I was thinking jump in the deep end, and go for uv and trusted publishing... That being said, I like simplicity of this PR.

I'll get back to this after #1186 where pyproject.toml is introduced and perhaps setup.py can be dropped.

@dimaqq
Copy link
Contributor

dimaqq commented Nov 14, 2024

WDYT about this: cb4a962 inspired by your PR?

@dimbleby
Copy link
Author

If you want to work in uv-world then I would simply replace python -m build with uv build.

Your commit leaves a virtualenv created but unused - though that is a side-issue.

I'm here not as a user but just someone trying to make the python ecosystem better, one project at a time...

@dimaqq
Copy link
Contributor

dimaqq commented Nov 15, 2024

Thank you @dimbleby , I didn't think uv build would work out of the box, but it does indeed!

Incorporated into f5b93e7

@dimaqq
Copy link
Contributor

dimaqq commented Nov 19, 2024

Closing this PR, as I've added uv build in #1186

@dimaqq dimaqq closed this Nov 19, 2024
@dimaqq
Copy link
Contributor

dimaqq commented Nov 19, 2024

Thank you for pointing me to the obvious!

@dimbleby dimbleby mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants