chore: ruff up the codebase #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
I've reviewed the full diff on github. |
james-garner-canonical
approved these changes
Nov 18, 2024
Contributor
james-garner-canonical
left a comment
james-garner-canonical
left a comment
There was a problem hiding this comment.
Went through this with Dima in a video call, and I think we're good to land this now
Contributor
Author
|
/merge |
This was referenced Nov 19, 2024
jujubot
added a commit
that referenced
this pull request
May 23, 2025
…ng-to-existing-model #1265 #### Description #1044 fixed proxy object reuse some time ago I accidentally undid that change in #1186 as I didn't realise that multiple connect/close calls were expected on a given instance. This PR re-applies the change, and cleans up init. (I've rearranged the initialisation order, because `__del__()` is run on a partially-initialised instance if `__init__()` fails half-way through. That's something that happens in unit tests, although unlikely to affect legitimate use.) Fixes: #1264 creating offer fails when connecting to existing model #### QA Steps - No regression in unit or integration tests - Eyeball the code change All CI tests need to pass. Fixes #1264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In short, we'll be relying on ruff via pre-commit as opposed to flake8 via tox.
FIXMEwhere public API could break or code change is not obvious or where too much manual work is required, those can be fixed in separate PRsCheck list