Conversation
darcywong00
reviewed
Dec 11, 2017
| return oldText; | ||
| osk.renameSpecialKey = function(oldText) { | ||
| // If a 'special key' mapping exists for the text, replace it with its corresponding special OSK character. | ||
| return osk.specialCharacters[oldText] ? String.fromCharCode(0XE000 + osk.specialCharacters[oldText]) : oldText; |
Contributor
There was a problem hiding this comment.
Won't this throw if oldText isn't found in specialCharacters?
Contributor
Author
There was a problem hiding this comment.
If oldText isn't found in specialCharacters, JavaScript will return undefined.
From there, undefined ? 'a' : 'b' returns 'b'.
darcywong00
previously approved these changes
Dec 12, 2017
mcdurdin
requested changes
Jan 3, 2018
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
This shouldn't be approved as it is still WIP
mcdurdin
approved these changes
Feb 12, 2018
This was referenced Feb 15, 2018
kingsuper195
pushed a commit
to kingsuper195/keyman
that referenced
this pull request
Jan 16, 2026
feat: add /jobs page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #340.
The only item remaining for #340 should be the need stress-testing of the new chiral features (overall), which may be possible soon via automation with #585.