Skip to content

Crystax support for Feedparser#1322

Closed
kuzeyron wants to merge 1 commit into
kivy:masterfrom
kuzeyron:patch-1
Closed

Crystax support for Feedparser#1322
kuzeyron wants to merge 1 commit into
kivy:masterfrom
kuzeyron:patch-1

Conversation

@kuzeyron

@kuzeyron kuzeyron commented Aug 8, 2018

Copy link
Copy Markdown
Contributor

Added python3crystax to the list.

@AndreMiras AndreMiras left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.
The commit title is not meaningful enough. Commit body can explain why this is needed, what error it solves

@kuzeyron kuzeyron changed the title Update __init__.py Crystax support for Feedparser Aug 9, 2018
@AndreMiras

Copy link
Copy Markdown
Member

Closing in favor of #1324
Please note that you should normally just amend your commit rather than creating a new pull request each time you need to make a little change.

@AndreMiras AndreMiras closed this Aug 9, 2018
@kuzeyron

kuzeyron commented Aug 9, 2018

Copy link
Copy Markdown
Contributor Author

@AndreMiras I couldn't find the place to change on the old one. So if I would be you, do the changes instead of having this odd game.

@AndreMiras

Copy link
Copy Markdown
Member

I cannot do the changes myself to your PR unless you explicitly give access to it.
Reading this article could help you https://medium.com/@igor_marques/git-basics-adding-more-changes-to-your-last-commit-1629344cb9a8
It's very useful trick, give it a try, it's easy once you know it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants