Crystax support for Feedparser#1324
Conversation
|
Hi @kuzeyron thanks for the pull request. Could you please fix a couple of issues:
|
|
@AndreMiras I edited that line in the webbrowser. Then I made a pull request through git. But I can't see it anywhere. I don't think I changed the whitespace on the file. Only directly added the crystax part. |
|
OK I see, it's a good opportunity for you to learn a bit more about git/GitHub and the shell. git clone git@github.com:kuzeyron/python-for-android.gitAnd then work on it, the workflow should be something like: cd python-for-android/
git reset --soft HEAD~1
vim pythonforandroid/recipes/feedparser/__init__.py
tox
git add pythonforandroid/recipes/feedparser/__init__.py
git commit --amendBasically the |
|
@kuzeyron @AndreMiras https://github.com/servo/servo/wiki/Beginner's-guide-to-rebasing-and-squashing let git do the work :) also, git's documentation is quite nice nowadays. |
|
@kuzeyron ping 😄 |
|
Hey André! I haven't had any interests in trying to re-PR the Feedparser. |
In this PR I've added support for Feedparser to work with python3crystax.