Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Clean up Hugo deprecation warnings.#198

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
evankanderson:fix-warning
Aug 15, 2020
Merged

Clean up Hugo deprecation warnings.#198
knative-prow-robot merged 2 commits into
knative:masterfrom
evankanderson:fix-warning

Conversation

@evankanderson
Copy link
Copy Markdown
Member

@evankanderson evankanderson commented Aug 4, 2020

Fixes the following warnings, updates to the latest version of the Docsy theme

WARN 2020/08/04 14:26:46 Page.Hugo is deprecated and will be removed in a future release. Use the global hugo function.
WARN 2020/08/04 14:26:46 Page.Dir is deprecated and will be removed in a future release. Use .File.Dir

  Replace Autoprefixer browsers option to Browserslist config.
  Use browserslist key in package.json or .browserslistrc file.

  Using browsers option cause some error. Browserslist config 
  can be used for Babel, Autoprefixer, postcss-normalize and other tools.

  If you really need to use option, rename it to overrideBrowserslist.

  Learn more at:
  https://github.com/browserslist/browserslist#readme
  https://twitter.com/browserslist

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 4, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2020
@evankanderson evankanderson mentioned this pull request Aug 4, 2020
Merged
@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Aug 4, 2020

Staged sample: https://5f29e5a2c46b2900081b06d7--knative.netlify.app/

Deploy log without errors: https://app.netlify.com/sites/knative/deploys/5f29e5a2c46b2900081b06d7

@evankanderson evankanderson mentioned this pull request Aug 4, 2020
Merged
evankanderson
evankanderson commented Aug 5, 2020
View reviewed changes
Comment thread assets/scss/main.scss
@import "../vendor/Font-Awesome//web-fonts-with-css/scss/fa-brands.scss";
@import "../vendor/Font-Awesome/scss/fontawesome.scss";
@import "../vendor/Font-Awesome/scss/solid.scss";
@import "../vendor/Font-Awesome/scss/brands.scss";
Copy link
Copy Markdown
Member Author

@evankanderson evankanderson Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/FortAwesome/Font-Awesome/blob/master/UPGRADING.md gave the hints, particularly:

5.1.0->5.1.1
5.5.0-5.6.0

@RichieEscarez RichieEscarez self-assigned this Aug 7, 2020
@RichieEscarez
Copy link
Copy Markdown
Contributor

RichieEscarez commented Aug 7, 2020 •
edited
Loading

FYI, part of the reason nobody attempted to update the Docsy version was that we were on one of the very first alpha-level versions and a lot has changed since then. I will spend some time clicking through most pages and running link checking randomly to make sure none of our Knative customizations have broken. Thanks for this and #200 to get us up-to-date!

RichieEscarez
RichieEscarez approved these changes Aug 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@RichieEscarez RichieEscarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything works. Its great to know that updating the Docsy submodule is transparent. Thanks again @evankanderson !

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit f312680 into knative:master Aug 15, 2020
@evankanderson evankanderson deleted the fix-warning branch March 23, 2021 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@samodell samodell Awaiting requested review from samodell

1 more reviewer

@RichieEscarez RichieEscarez RichieEscarez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RichieEscarez RichieEscarez

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evankanderson @RichieEscarez @knative-prow-robot @googlebot