Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Upgrade to Hugo 0.74.3, fix knative/docs#2706#200

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
evankanderson:finish-upgrade
Aug 19, 2020
Merged

Upgrade to Hugo 0.74.3, fix knative/docs#2706#200
knative-prow-robot merged 2 commits into
knative:masterfrom
evankanderson:finish-upgrade

Conversation

@evankanderson
Copy link
Copy Markdown
Member

@evankanderson evankanderson commented Aug 4, 2020 •
edited
Loading

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 4, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2020
@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Aug 4, 2020

This needs #198 to merge first.

@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Aug 4, 2020

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2020
@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Aug 6, 2020

Fixes knative/docs#2706

@RichieEscarez RichieEscarez mentioned this pull request Aug 7, 2020
Merged
@RichieEscarez RichieEscarez added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2020
@RichieEscarez RichieEscarez self-assigned this Aug 17, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2020
@RichieEscarez
Copy link
Copy Markdown
Contributor

RichieEscarez commented Aug 17, 2020

This needs a rebase (even though Prow thinks otherwise). These errors are causing the build to fail:

2:07:21 PM: Building sites … WARN 2020/08/17 21:07:21 Page.Dir is deprecated and will be removed in a future release. Use .File.Dir
2:07:30 PM: Total in 10079 ms
2:07:30 PM: Error: Error building site: TOCSS: failed to transform "scss/main.scss" (text/x-scss): SCSS processing failed: file "stdin", line 8, col 1: File to import not found or unreadable: ../vendor/Font-Awesome//web-fonts-with-css/scss/fontawesome.scss.

@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Aug 19, 2020

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
grantr
grantr reviewed Aug 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@knative-prow-robot knative-prow-robot merged commit 1f11971 into knative:master Aug 19, 2020
@evankanderson evankanderson deleted the finish-upgrade branch March 23, 2021 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@samodell samodell Awaiting requested review from samodell

1 more reviewer

@grantr grantr grantr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@grantr grantr

@RichieEscarez RichieEscarez

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code Boxes form collapses in Knative Documentation

5 participants

@evankanderson @knative-prow-robot @RichieEscarez @grantr @googlebot