feat: labelle plugins listing + license/author metadata (#300) by apotema · Pull Request #306 · labelle-toolkit/labelle-cli

apotema · 2026-07-10T17:25:38Z

Asset Plugins Phase 2 — CLI side (#300)

Adds a labelle plugins [dir] subcommand that surfaces plugin provenance: for each plugin declared in project.labelle's .plugins list it reads that plugin's plugin.labelle and prints an aligned table of name, declared version, license, author.

Example

PLUGIN               VERSION  LICENSE  AUTHOR
atlas-overlay        1.2.0    MIT      Acme Games
nolicense            0.3.0    -        -
labelle-pathfinding  4.0.1    -        -

What's in it

src/cli/plugins.zig
- readPluginMeta — parses name / manifest_version plus the new optional license / author fields via std.zon.parse.fromSliceAlloc with .ignore_unknown_fields = true. A missing plugin.labelle (legal — many plugins ship none) or a malformed one is tolerated: the row falls back to - rather than aborting the listing.
- resolvePluginDir — mirrors the local (local:/@) vs remote (~/.labelle/packages/plugins/<repo>/<version>) resolution the lockfile writer already uses.
- renderTable — a pure, unit-testable aligned-table renderer.
Wired into cli.zig dispatch as a standalone command (reads project.labelle itself; clean exit-1 + guidance when run outside a project) and surfaced in labelle help.
Tests (zspec): reader parses full metadata, tolerates missing license/author and a missing file; renderer emits a header + rows with - placeholders. zig build test is green.

Dependency-ordering note

The generate-time depends_on_resources validation (an undeclared game-atlas dependency failing generate) is delivered assembler-side in labelle-assembler#576 — the CLI shells out to the labelle-assembler binary for generate and never parses the merged resource set, so it cannot meaningfully perform that validation locally. #300's CLI deliverable is this provenance-surfacing listing plus the license/author reader; the two land as a pair.

Closes #300

https://claude.ai/code/session_017pW3ifKf9wgxNg4viy6okw

Asset Plugins Phase 2, CLI side. Adds a `labelle plugins [dir]` subcommand that reads each declared plugin's `plugin.labelle` and prints an aligned table of plugin name, declared version, license, and author. - src/cli/plugins.zig: `readPluginMeta` parses name/manifest_version and the optional license/author (ignore_unknown_fields; tolerates a missing or malformed manifest by falling back to `-`), `resolvePluginDir` mirrors the local/remote resolution used by the lockfile writer, and a pure `renderTable` for testable aligned output. - Wired into cli.zig dispatch (standalone, reads project.labelle itself) and surfaced in `labelle help`. - zspec tests: reader parses full metadata, tolerates missing license/author + missing file; renderer emits header + rows with `-` placeholders. Generate-time `depends_on_resources` validation is delivered assembler -side (labelle-assembler#576); the CLI shells out to the assembler for `generate` and never parses the merged resource set, so #300's CLI deliverable is this provenance-surfacing listing. Closes #300 Claude-Session: https://claude.ai/code/session_017pW3ifKf9wgxNg4viy6okw

coderabbitai · 2026-07-10T17:25:47Z

Warning

Review limit reached

@apotema, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2cf82767-c071-4a7d-a7ea-af09530f90dd

📥 Commits

Reviewing files that changed from the base of the PR and between b7cef99 and 24e8e17.

📒 Files selected for processing (3)

src/cli.zig
src/cli/help.zig
src/cli/plugins.zig

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/300-depends-on-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

gemini-code-assist

Code Review

This pull request implements the plugins command for the labelle CLI, allowing users to list attached plugins alongside their version, license, and author metadata extracted from plugin.labelle manifests. The feedback focuses on improving memory safety and error handling in Zig by propagating OutOfMemory errors instead of swallowing them in readPluginMeta and resolvePluginDir, using errdefer to clean up partial allocations, and updating the command's call sites and test cases accordingly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-07-10T17:27:57Z

+pub fn readPluginMeta(allocator: std.mem.Allocator, plugin_dir: []const u8) ?PluginMeta {
+    const manifest_path = std.fs.path.join(allocator, &.{ plugin_dir, "plugin.labelle" }) catch return null;
+    defer allocator.free(manifest_path);
+
+    const raw = std.Io.Dir.cwd().readFileAlloc(config.globalIo(), manifest_path, allocator, .limited(64 * 1024)) catch |err| {
+        // FileNotFound is the common, legal "no manifest" case — stay
+        // silent. Anything else is worth a diagnostic breadcrumb.
+        if (err != error.FileNotFound) {
+            std.debug.print("labelle: warning: could not read '{s}': {s}\n", .{ manifest_path, @errorName(err) });
+        }
+        return null;
+    };
+    defer allocator.free(raw);
+
+    const raw_z = allocator.dupeZ(u8, raw) catch return null;
+    defer allocator.free(raw_z);
+
+    const parsed = std.zon.parse.fromSliceAlloc(ZonPluginMeta, allocator, raw_z, null, .{
+        .ignore_unknown_fields = true,
+    }) catch |err| {
+        std.debug.print("labelle: warning: could not parse '{s}': {s} — listing it without license/author\n", .{ manifest_path, @errorName(err) });
+        return null;
+    };
+    // The parser deep-copies strings; free the whole parsed value after
+    // re-duping the fields we keep so ownership is a single, simple
+    // `PluginMeta.deinit`.
+    defer std.zon.parse.free(allocator, parsed);
+
+    const name = allocator.dupe(u8, parsed.name) catch return null;
+    const license = if (parsed.license) |l| (allocator.dupe(u8, l) catch null) else null;
+    const author = if (parsed.author) |a| (allocator.dupe(u8, a) catch null) else null;
+
+    return PluginMeta{
+        .name = name,
+        .manifest_version = parsed.manifest_version,
+        .license = license,
+        .author = author,
+        .allocator = allocator,
+    };
+}


In Zig, system-level failures like OutOfMemory should always be propagated rather than swallowed as a generic failure or missing file. Swallowing OutOfMemory makes debugging memory pressure issues extremely difficult.

Additionally, when initializing a resource that will have its ownership transferred later, we should use errdefer to ensure that any successfully allocated fields (like name or license) are properly deallocated if a subsequent allocation fails before the PluginMeta struct is fully constructed and returned.

Let's update readPluginMeta to return !?PluginMeta, propagate OutOfMemory errors, and use errdefer for safe cleanup.

pub fn readPluginMeta(allocator: std.mem.Allocator, plugin_dir: []const u8) !?PluginMeta { const manifest_path = std.fs.path.join(allocator, &.{ plugin_dir, "plugin.labelle" }) catch |err| { if (err == error.OutOfMemory) return error.OutOfMemory; return null; }; defer allocator.free(manifest_path); const raw = std.Io.Dir.cwd().readFileAlloc(config.globalIo(), manifest_path, allocator, .limited(64 * 1024)) catch |err| { if (err == error.OutOfMemory) return error.OutOfMemory; // FileNotFound is the common, legal "no manifest" case — stay // silent. Anything else is worth a diagnostic breadcrumb. if (err != error.FileNotFound) { std.debug.print("labelle: warning: could not read '{s}': {s}\n", .{ manifest_path, @errorName(err) }); } return null; }; defer allocator.free(raw); const raw_z = allocator.dupeZ(u8, raw) catch |err| { if (err == error.OutOfMemory) return error.OutOfMemory; return null; }; defer allocator.free(raw_z); const parsed = std.zon.parse.fromSliceAlloc(ZonPluginMeta, allocator, raw_z, null, .{ .ignore_unknown_fields = true, }) catch |err| { if (err == error.OutOfMemory) return error.OutOfMemory; std.debug.print("labelle: warning: could not parse '{s}': {s} — listing it without license/author\n", .{ manifest_path, @errorName(err) }); return null; }; // The parser deep-copies strings; free the whole parsed value after // re-duping the fields we keep so ownership is a single, simple // `PluginMeta.deinit`. defer std.zon.parse.free(allocator, parsed); const name = try allocator.dupe(u8, parsed.name); errdefer allocator.free(name); const license = if (parsed.license) |l| try allocator.dupe(u8, l) else null; errdefer if (license) |l| allocator.free(l); const author = if (parsed.author) |a| try allocator.dupe(u8, a) else null; return PluginMeta{ .name = name, .manifest_version = parsed.manifest_version, .license = license, .author = author, .allocator = allocator, }; }

References

In Zig, when initializing a resource that will have its ownership transferred later, use errdefer (potentially combined with an ownership flag) to ensure the resource is properly deinitialized if an error occurs before the transfer is complete.

gemini-code-assist · 2026-07-10T17:27:57Z

+        if (resolvePluginDir(a, project_dir, dep)) |plugin_dir| {
+            if (readPluginMeta(a, plugin_dir)) |meta| {
+                if (meta.license) |l| license = l;
+                if (meta.author) |au| author = au;
+            }
+        }


Since resolvePluginDir and readPluginMeta now propagate OutOfMemory errors, we should use try at their call sites in cmdPlugins to correctly bubble up any allocation failures.

if (try resolvePluginDir(a, project_dir, dep)) |plugin_dir| { if (try readPluginMeta(a, plugin_dir)) |meta| { if (meta.license) |l| license = l; if (meta.author) |au| author = au; } }

gemini-code-assist · 2026-07-10T17:27:57Z

+            var meta = readPluginMeta(std.testing.allocator, dir).?;
+            defer meta.deinit();
+
+            try std.testing.expectEqualStrings("atlas-overlay", meta.name);
+            try expect.equal(meta.manifest_version, @as(u8, 1));
+            try std.testing.expectEqualStrings("MIT", meta.license.?);
+            try std.testing.expectEqualStrings("Acme Games", meta.author.?);


Update the test cases to use try when calling readPluginMeta to match its new error-propagating signature.

var meta = (try readPluginMeta(std.testing.allocator, dir)).?; defer meta.deinit(); try std.testing.expectEqualStrings("atlas-overlay", meta.name); try expect.equal(meta.manifest_version, @as(u8, 1)); try std.testing.expectEqualStrings("MIT", meta.license.?); try std.testing.expectEqualStrings("Acme Games", meta.author.?);

gemini-code-assist · 2026-07-10T17:27:57Z

+            var meta = readPluginMeta(std.testing.allocator, dir).?;
+            defer meta.deinit();
+
+            try std.testing.expectEqualStrings("bare", meta.name);
+            try expect.toBeNull(meta.license);
+            try expect.toBeNull(meta.author);


Update the test cases to use try when calling readPluginMeta to match its new error-propagating signature.

var meta = (try readPluginMeta(std.testing.allocator, dir)).?; defer meta.deinit(); try std.testing.expectEqualStrings("bare", meta.name); try expect.toBeNull(meta.license); try expect.toBeNull(meta.author);

gemini-code-assist · 2026-07-10T17:27:57Z

+            try expect.toBeNull(readPluginMeta(std.testing.allocator, dir));
+        }


Update the test cases to use try when calling readPluginMeta to match its new error-propagating signature.

try expect.toBeNull(try readPluginMeta(std.testing.allocator, dir)); }

gemini-code-assist · 2026-07-10T17:27:57Z

+fn resolvePluginDir(
+    allocator: std.mem.Allocator,
+    project_dir: []const u8,
+    dep: project_config.PluginDep,
+) ?[]const u8 {
+    if (dep.isLocal())
+        return std.fs.path.resolve(allocator, &.{ project_dir, dep.localPath() }) catch null;
+    return asm_cache.resolveRemotePluginDir(allocator, dep.repo, dep.version) catch null;
+}


Similar to readPluginMeta, resolvePluginDir should propagate OutOfMemory errors instead of swallowing them with catch null. Let's update the signature to return !?[]const u8 and explicitly propagate OutOfMemory while falling back to null for other resolution errors.

fn resolvePluginDir( allocator: std.mem.Allocator, project_dir: []const u8, dep: project_config.PluginDep, ) !?[]const u8 { if (dep.isLocal()) return std.fs.path.resolve(allocator, &.{ project_dir, dep.localPath() }) catch |err| { if (err == error.OutOfMemory) return error.OutOfMemory; return null; }; return asm_cache.resolveRemotePluginDir(allocator, dep.repo, dep.version) catch |err| { if (err == error.OutOfMemory) return error.OutOfMemory; return null; }; }

Review follow-up on #300: `readPluginMeta` and `resolvePluginDir` used `catch → null` on every fallible call, which quietly dropped a plugin from the listing on a real allocation failure. Make both fallible: - `readPluginMeta` now returns `error{OutOfMemory}!?PluginMeta`; OOM from path.join / dupeZ / the ZON parser / the field dupes propagates, while the legitimate "no manifest (FileNotFound)", unreadable, or unparseable cases still degrade to `null` with a warning. Added errdefers so a mid-way OOM doesn't leak the already-duped name/license. - `resolvePluginDir` now returns `![]const u8` (no optional): resolution is pure path construction with no "not found" case, so OOM / NoHomeDirectory surface instead of collapsing to null. - Callers + the three test sites updated to `try`. Claude-Session: https://claude.ai/code/session_017pW3ifKf9wgxNg4viy6okw

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3d8ae3b94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-10T17:41:34Z

+            if (readPluginMeta(a, plugin_dir)) |meta| {
+                if (meta.license) |l| license = l;
+                if (meta.author) |au| author = au;


Validate manifest names before using provenance

When a local path points at the wrong plugin, or a remote cache contains a stale/corrupt plugin.labelle whose .name differs from the .plugins entry, this block still copies that manifest's license/author into the row labelled with dep.name. That misattributes provenance for a different plugin; compare meta.name with dep.name and warn/fall back to placeholders before using these fields.

Useful? React with 👍 / 👎.

gemini-code-assist Bot reviewed Jul 10, 2026

View reviewed changes

apotema merged commit 84a9d36 into main Jul 10, 2026
6 checks passed

apotema deleted the feat/300-depends-on-validation branch July 10, 2026 17:40

chatgpt-codex-connector Bot reviewed Jul 10, 2026

View reviewed changes

Navigation Menu

Uh oh!

feat: labelle plugins listing + license/author metadata (#300) - #306

feat: labelle plugins listing + license/author metadata (#300)#306
apotema merged 2 commits into
mainfrom
feat/300-depends-on-validation

apotema commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

Review limit reached

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		try expect.toBeNull(readPluginMeta(std.testing.allocator, dir));
		}

Uh oh!

Conversation

apotema commented Jul 10, 2026

Asset Plugins Phase 2 — CLI side (#300)

Example

What's in it

Dependency-ordering note

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading