optimize: remove fenced code block guidance from auth URL output hints#1088
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR updates auth device-flow login messages and documentation to refine QR code display guidance. The ChangesQR Code Display Guidance Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
=======================================
Coverage 67.85% 67.85%
=======================================
Files 592 592
Lines 55373 55373
=======================================
Hits 37574 37574
Misses 14685 14685
Partials 3114 3114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@98d585c5162f88ab4e0ae61ac511f34c99667c64🧩 Skill updatenpx skills add larksuite/cli#feat/auth_hint -y -g |
Summary
Remove fenced code block guidance from auth URL output hints. Wrapping verification_url in code blocks makes the link unclickable for end users; the existing "opaque string, do not modify" constraint is sufficient to prevent AI agents from altering the URL.
Changes
cmd/auth/login_messages.go--no-wait --jsonhint incmd/auth/login.goskills/lark-shared/SKILL.mdcmd/auth/login_test.goto matchTest Plan
go test ./cmd/auth/ -count=1)lark-cli auth logincommand works as expectedRelated Issues
Summary by CodeRabbit