fix: guide agents to yield during auth device flow#933
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughUpdated device-flow authentication guidance and tests to recommend a non-blocking split-flow for AI agents: obtain the verification URL with ChangesDevice-flow split-flow guidance refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e6a7435 to
984a5ab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
=======================================
Coverage 65.92% 65.92%
=======================================
Files 523 523
Lines 49692 49694 +2
=======================================
+ Hits 32758 32760 +2
Misses 14134 14134
Partials 2800 2800 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@984a5ab165b36bfea2370b75dbd61b2b4b7918d5🧩 Skill updatenpx skills add LawyerLyu/cli#fix/auth-device-flow-agent-guidance -y -g |
Summary
Fixes the device-flow guidance for AI agents so non-streaming harnesses do not block the same turn that is supposed to deliver the verification URL to the user.
Changes
auth login --helpand no-flags guidance to recommend the--no-wait --jsonsplit-flow for non-streaming agent harnesses.auth login --no-waitJSONhintto tell agents to present the URL as the final message of the turn and poll--device-codelater after the user confirms authorization.lark-sharedskill guidance with the same yield pattern.Test Plan
go test ./cmd/authlark xxxcommand works as expected: auth help/no-wait guidance is covered by tests and produces the updated split-flow wordingRelated Issues
Summary by CodeRabbit
Improvements
Tests
Documentation