docs: optimize lark-drive skill routing#1284
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
📝 WalkthroughWalkthroughCondenses skills/lark-drive/SKILL.md into focused entry points, delegates comment, permission, reactions, and wiki-token routing details into new reference guides, updates shortcuts and doubao.com routing rules, and removes the in-file permission table. ChangesDrive Skill Documentation Restructuring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
=======================================
Coverage 71.90% 71.90%
=======================================
Files 691 691
Lines 65629 65629
=======================================
+ Hits 47191 47193 +2
+ Misses 14791 14790 -1
+ Partials 3647 3646 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@dba9ac6887ee435975a508b11d53c7e3e0333cd8🧩 Skill updatenpx skills add larksuite/cli#docs/lark-drive-skill-routing -y -g |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
skills/lark-drive/references/lark-drive-permission-guide.md (1)
16-16: 💤 Low valueConsider clarifying the URL recovery process.
The guidance to "recover URL from context, search results, or metadata" when only a token is available could benefit from a concrete example or reference to the
drive +inspectcapability mentioned in the main SKILL.md. This would help implementers understand the recommended recovery workflow.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-drive/references/lark-drive-permission-guide.md` at line 16, The guidance is vague about recovering a document URL from a token (when error codes 91011/91012 occur); update the text to include a concrete recovery workflow: when only a token is available, first call the drive +inspect capability with the token to retrieve metadata (title, fileId, path), then attempt to reconstruct the document URL from returned fileId/path; if +inspect fails, fall back to a search by title or SHA using available context and search results, and finally present the reconstructed URL as a clickable link; mention the specific use of "drive +inspect" and the token error codes (91011/91012) so implementers know the exact steps to follow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@skills/lark-drive/references/lark-drive-permission-guide.md`:
- Line 16: The guidance is vague about recovering a document URL from a token
(when error codes 91011/91012 occur); update the text to include a concrete
recovery workflow: when only a token is available, first call the drive +inspect
capability with the token to retrieve metadata (title, fileId, path), then
attempt to reconstruct the document URL from returned fileId/path; if +inspect
fails, fall back to a search by title or SHA using available context and search
results, and finally present the reconstructed URL as a clickable link; mention
the specific use of "drive +inspect" and the token error codes (91011/91012) so
implementers know the exact steps to follow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b4784842-b8f6-414d-a1d9-252ebff6d213
📒 Files selected for processing (5)
skills/lark-drive/SKILL.mdskills/lark-drive/references/lark-drive-comments-guide.mdskills/lark-drive/references/lark-drive-permission-guide.mdskills/lark-drive/references/lark-drive-reactions.mdskills/lark-shared/references/lark-wiki-token-routing.md
0545e0d to
1ee1b5e
Compare
Change-Id: I79cebaa3e52b9291c89bdeffb50426e8f0f3bb2b
Change-Id: I628291d6d2b60b0baa7202dddbb9a34138a27a3d
1ee1b5e to
dba9ac6
Compare
Summary
Optimize the lark-drive skill routing and main skill size while preserving core Drive capabilities and detailed guidance through references.
Changes
Test Plan
lark-cli <domain> <command>flow works as expected via skill/doc checks belowgit diff --checknode scripts/skill-format-check/index.jsbash scripts/check-doc-tokens.sh skills/lark-drivebash scripts/check-doc-tokens.sh skills/lark-sharedRelated Issues
Summary by CodeRabbit