docs: add lark-drive permission governance workflow#1292
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds comprehensive lark-drive documentation and SKILL routing for a new permission_governance workflow: master workflow framework, the permission_governance specification with state machine and rules, a CLI command reference, detailed user-facing output templates, and SKILL.md routing to the workflow. ChangesPermission Governance Workflow System
Sequence Diagram(s)sequenceDiagram
participant User
participant Agent
participant WorkflowRegistry
participant PermissionGovernance
participant DriveAPI
User->>Agent: request permission governance
Agent->>WorkflowRegistry: lookup workflow (permission_governance)
WorkflowRegistry->>PermissionGovernance: load entry & references
PermissionGovernance->>DriveAPI: discovery & fact read commands
PermissionGovernance->>Agent: render diagnostics / request confirmation
Agent->>PermissionGovernance: user confirmation
PermissionGovernance->>DriveAPI: execute writes (permission/owner/label)
PermissionGovernance->>DriveAPI: fresh read for verification
PermissionGovernance->>Agent: final summary / verification results
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@skills/lark-drive/references/lark-drive-workflow-permission-governance-commands.md`:
- Around line 80-121: The doc currently shows +secure-label-update without first
listing available labels, which breaks the EXEC_CONFIRM contract; add a
secure-label enumeration example (using the command symbol +secure-label-list)
immediately before +secure-label-update in the "写前确认与执行" section so users can
discover label IDs to confirm, and ensure the example matches the flag style
used elsewhere (--token/--type/--label-id, --as user, --format json) to keep
consistency with permission.members auth and +secure-label-update entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fc2d23e3-1aaa-4e91-9927-5e9cf3e6b82f
📒 Files selected for processing (5)
skills/lark-drive/SKILL.mdskills/lark-drive/references/lark-drive-workflow-permission-governance-commands.mdskills/lark-drive/references/lark-drive-workflow-permission-governance-outputs.mdskills/lark-drive/references/lark-drive-workflow-permission-governance.mdskills/lark-drive/references/lark-drive-workflow.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@cbb6cf80e75572deade59bb47dd92a8372606764🧩 Skill updatenpx skills add larksuite/cli#docs/lark-drive-permission-governance -y -g |
86bdd52 to
0873d47
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1292 +/- ##
=======================================
Coverage 72.83% 72.83%
=======================================
Files 732 732
Lines 69140 69140
=======================================
Hits 50356 50356
Misses 15003 15003
Partials 3781 3781 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@skills/lark-drive/references/lark-drive-workflow-permission-governance-commands.md`:
- Line 27: The wiki node-list command currently misdocuments/behaves for
pagination and subtree recursion: in shortcuts/wiki/wiki_node_list.go update the
pagination logic so that the --page-limit flag treats 0 as "unlimited" (i.e., no
cap), implement --page-all to iterate pages until no more results but still
respect a non-zero --page-limit as a hard cap, and ensure page-all only drains
pagination for the current space-id/parent-node-token scope (do not auto-recurse
into children); also ensure has_child remains a marker only and deeper traversal
requires explicit additional calls using --parent-node-token. Use the existing
flag variables/handlers for --page-all and --page-limit and the has_child check
in the node listing flow to locate where to change the loop/limit logic and
recursion behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bfff7527-bee6-447b-af99-6706c751b004
📒 Files selected for processing (5)
skills/lark-drive/SKILL.mdskills/lark-drive/references/lark-drive-workflow-permission-governance-commands.mdskills/lark-drive/references/lark-drive-workflow-permission-governance-outputs.mdskills/lark-drive/references/lark-drive-workflow-permission-governance.mdskills/lark-drive/references/lark-drive-workflow.md
✅ Files skipped from review due to trivial changes (2)
- skills/lark-drive/SKILL.md
- skills/lark-drive/references/lark-drive-workflow.md
Change-Id: Ib62bd439669fec3e9d5589d1fbe266d3aef964a8
b31981f to
cbb6cf8
Compare
Summary
Add and refine the registered
permission_governanceworkflow forlark-driveso AI agents can audit, report, and govern Drive / Docs / Wiki permission risks with explicit capability boundaries and write-safety gates. This update also aligns owner-transfer routing, public-permission semantic rendering, and user-facing output templates with the current CLI schema and official OpenAPI terminology.Changes
SKILL.mdthrough the workflow registry.Test Plan
node scripts/skill-format-check/index.jspassedbash scripts/check-doc-tokens.sh skills/lark-drivepassedbash scripts/check-skill-wire-vocab.shpassedgit diff --check -- skills/lark-drive/SKILL.md skills/lark-drive/references/lark-drive-workflow.md skills/lark-drive/references/lark-drive-workflow-permission-governance.md skills/lark-drive/references/lark-drive-workflow-permission-governance-outputs.md skills/lark-drive/references/lark-drive-workflow-permission-governance-commands.mdpassedlark-cli schema drive.permission.public.get --format jsonlark-cli schema drive.permission.members.transfer_owner --format jsonRelated Issues
Summary by CodeRabbit
New Features
Documentation