Skip to content

docs(skills): tighten drive and markdown retry guardrails - #1326

Merged
fangshuyu-768 merged 1 commit into
mainfrom
feat/skill-error-handling-guardrails
Jun 8, 2026
Merged

docs(skills): tighten drive and markdown retry guardrails#1326
fangshuyu-768 merged 1 commit into
mainfrom
feat/skill-error-handling-guardrails

Conversation

@fangshuyu-768

@fangshuyu-768 fangshuyu-768 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add drive-skill guidance to stop after terminal inspect or upload failures instead of guessing downstream commands
  • add markdown-skill guidance to distinguish bot vs user failures and avoid retrying terminal create or overwrite errors

Testing

  • docs-only change; not applicable

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ca3f49d6-7d4a-4fd1-afe5-f05f2efddee2

📥 Commits

Reviewing files that changed from the base of the PR and between 611cceb and e08990c.

📒 Files selected for processing (2)
  • skills/lark-drive/SKILL.md
  • skills/lark-markdown/SKILL.md
✅ Files skipped from review due to trivial changes (2)
  • skills/lark-drive/SKILL.md
  • skills/lark-markdown/SKILL.md

📝 Walkthrough

Walkthrough

This PR updates guidance documentation in two CLI skill definition files to clarify error-handling strategies: drive operations now require type inspection before proceeding with wiki URLs, and markdown operations now recommend identity diagnosis before switching execution contexts, with both skills applying consistent retry-stop policies for terminal errors.

Changes

Error Handling and Routing Guidance

Layer / File(s) Summary
Drive operation type resolution and retry guidance
skills/lark-drive/SKILL.md
Wiki URL/token handling now requires drive +inspect for type resolution first; automatic fallback is prevented on failure, and retries default to stopping on not-found, permission-denied, and missing-scope errors, with limited retry for rate-limit or temporary network errors.
Markdown operation identity diagnosis and retry policy
skills/lark-markdown/SKILL.md
Markdown operation failures now instruct diagnosing identity vs. permission issues before switching --as identities; retry behavior aligns with drive by stopping on missing-scope, permission-denied, not-found, and version-limit errors, retrying only on rate-limit or temporary network errors.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • larksuite/cli#947: Introduced the drive +inspect shortcut for wiki-unwrapping behavior, which the drive guidance in this PR now references directly.
  • larksuite/cli#505: Updated SKILL.md to prioritize --as user and limit retries on permission errors, aligning with the identity-diagnosis and retry-stop guidance added here.
  • larksuite/cli#1279: Expanded markdown execution-identity guidance (e.g., --as user default), which overlaps with the markdown identity-diagnosis rules added in this PR.

Suggested labels

domain/ccm

Suggested reviewers

  • wittam-01
  • liangshuo-1

🐰 Hopping through docs with care,
Error hints make workflows fair,
No more fallback, identity clear,
Retry rules are crystal here!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs(skills): tighten drive and markdown retry guardrails' clearly and concisely summarizes the main change: improving documentation for error handling and retry policies in drive and markdown skills.
Description check ✅ Passed The PR description covers the summary of changes and notes it's a docs-only change, but omits the Test Plan and Related Issues sections specified in the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/skill-error-handling-guardrails

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/L Large or sensitive change across domains or core paths label Jun 8, 2026
@fangshuyu-768
fangshuyu-768 force-pushed the feat/skill-error-handling-guardrails branch from 611cceb to e08990c Compare June 8, 2026 10:29
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@e08990c94c7cd18cd8e37b62c3735aa3c71d1f99

🧩 Skill update

npx skills add larksuite/cli#feat/skill-error-handling-guardrails -y -g

@fangshuyu-768 fangshuyu-768 changed the title docs(skills): tighten error-handling guardrails docs(skills): tighten drive and markdown retry guardrails Jun 8, 2026
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.47%. Comparing base (99ceb22) to head (e08990c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage   71.47%   71.47%           
=======================================
  Files         688      688           
  Lines       65482    65482           
=======================================
  Hits        46806    46806           
  Misses      15031    15031           
  Partials     3645     3645           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fangshuyu-768
fangshuyu-768 merged commit d0a896c into main Jun 8, 2026
23 checks passed
@fangshuyu-768
fangshuyu-768 deleted the feat/skill-error-handling-guardrails branch June 8, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Large or sensitive change across domains or core paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants