fix: accept opaque wiki node tokens#1789
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughWiki node-list parent tokens now accept opaque values, and wiki node-get raw token parsing now uses ChangesWiki Token Validation Relaxation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1789 +/- ##
==========================================
- Coverage 74.40% 74.39% -0.01%
==========================================
Files 860 860
Lines 89215 89432 +217
==========================================
+ Hits 66384 66537 +153
- Misses 17701 17745 +44
- Partials 5130 5150 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@3416c1d5314726129b5620bba8ece18cd5b2a04d🧩 Skill updatenpx skills add larksuite/cli#fix/wiki-opaque-node-token -y -g |
09843eb to
f091b98
Compare
f091b98 to
3416c1d
Compare
Summary
Fix wiki shortcuts that treated the historical
wikprefix as a hard requirement for wiki node tokens. Newer or opaque wiki node tokens can now be passed through without being blocked by client-side validation.Changes
wiki +node-getso raw tokens without--obj-typeare treated as node tokens and--obj-typeis ignored for obvious wiki node tokens.wiki +node-list --parent-node-tokento validate raw token syntax only, while preserving URL type checks for non-wiki URLs.+node-getand+node-list.Test Plan
go test ./shortcuts/wikilark-cli wiki +node-listandlark-cli wiki +node-getdry-run flows work as expectedRelated Issues
Summary by CodeRabbit
--parent-node-tokennormalization to avoid incorrectly rejecting valid opaque values.--obj-typeparsing: raw node token mode now defaults when omitted, and--obj-typecleanly switches lookup behavior.WikiNodeGet--node-tokenand--obj-typehelp/usage wording for clearer URL inference and raw token behavior.obj_typebehavior.