feat(wiki): add +node-get / +node-delete / +space-create shortcuts#904
Merged
Conversation
github-actions
Bot
added
domain/ccm
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds three wiki shortcuts (+space-create, +node-get, +node-delete), shared async-task parsing/polling helpers, drive task_result support for wiki delete-node, refactors delete-space to use shared helpers, updates docs/registry, and adds comprehensive tests. ChangesWiki node operations
Sequence Diagram(s)sequenceDiagram
participant CLI
participant WikiAPI as Wiki API
participant TasksAPI as Tasks API
CLI->>WikiAPI: (optional) GET /open-apis/wiki/v2/spaces/get_node (resolve space_id)
CLI->>WikiAPI: DELETE /open-apis/wiki/v2/spaces/:space_id/nodes/:node_token
WikiAPI-->>CLI: {task_id?} (empty => sync ready)
CLI->>TasksAPI: poll /open-apis/wiki/v2/tasks/:task_id?task_type=delete_node
TasksAPI-->>CLI: {task_id,status,status_msg}
CLI->>CLI: pollWikiAsyncTask -> returns ready/failed/status/status_msg or resume hint
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
+ Coverage 65.95% 66.93% +0.98%
==========================================
Files 523 568 +45
Lines 49590 52970 +3380
==========================================
+ Hits 32707 35458 +2751
- Misses 14090 14581 +491
- Partials 2793 2931 +138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@7d8071fb00b002d0e1013189b85330f4b87cc287🧩 Skill updatenpx skills add larksuite/cli#feat/wiki-node-shortcuts -y -g |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
shortcuts/wiki/wiki_node_create_test.go (1)
114-126: ⚡ Quick winStrengthen this test to assert the newly added commands explicitly.
Checking only
len(shortcuts) == 9won’t catch a wrong/missing command if count stays the same. Add assertions for+space-create,+node-get, and+node-delete(or assert the full expected command list).Suggested test hardening
func TestWikiShortcutsIncludeAllCommands(t *testing.T) { t.Parallel() shortcuts := Shortcuts() if len(shortcuts) != 9 { t.Fatalf("len(Shortcuts()) = %d, want 9", len(shortcuts)) } + got := make([]string, 0, len(shortcuts)) + for _, sc := range shortcuts { + got = append(got, sc.Command) + } + want := []string{ + "+move", + "+node-create", + "+delete-space", + "+space-list", + "+space-create", + "+node-list", + "+node-copy", + "+node-get", + "+node-delete", + } + for i := range want { + if got[i] != want[i] { + t.Fatalf("shortcuts[%d].Command = %q, want %q", i, got[i], want[i]) + } + } - if shortcuts[0].Command != "+move" { - t.Fatalf("shortcuts[0].Command = %q, want %q", shortcuts[0].Command, "+move") - } - if shortcuts[1].Command != "+node-create" { - t.Fatalf("shortcuts[1].Command = %q, want %q", shortcuts[1].Command, "+node-create") - } - if shortcuts[2].Command != "+delete-space" { - t.Fatalf("shortcuts[2].Command = %q, want %q", shortcuts[2].Command, "+delete-space") - } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/wiki/wiki_node_create_test.go` around lines 114 - 126, The test in wiki_node_create_test.go currently only checks len(shortcuts) and a few commands; strengthen it by asserting the full expected command list or at minimum add explicit checks for the newly added commands: verify that shortcuts contains "+space-create", "+node-get", and "+node-delete" (in addition to existing checks for "+move", "+node-create", "+delete-space"), using the same pattern as the existing assertions against shortcuts[n].Command so the test fails if any command is missing or out of order.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/wiki/wiki_async_task.go`:
- Around line 165-172: The retry logic currently calls output.ErrWithHint which
rebuilds and loses structured API detail; instead, detect when lastErr is an
*output.ExitError (the existing exitErr variable) and preserve its Detail fields
(Code, ConsoleURL, Risk, nested Detail, etc.) while only appending the retry
hint to the message/hint field, then return the original or a minimally-updated
ExitError so structured fields are retained; update the branch handling
lastErr/exitErr around the existing output.ErrWithHint call to reuse
exitErr.Detail rather than reconstructing the error.
- Around line 65-73: The StatusCode method on wikiAsyncTaskStatus returns raw
non-empty statuses which can conflict with Failed(); update StatusCode() to
align with the helper's non-terminal classification by returning
wikiAsyncStatusProcessing for any status that is not explicitly ready/successful
or explicitly failed/terminal. In practice, inside StatusCode() (on
wikiAsyncTaskStatus) trim the value, then use the same readiness/terminal logic
used by Failed() (or call a shared helper) to detect non-terminal states and
coerce them to wikiAsyncStatusProcessing, otherwise return the original terminal
status.
---
Nitpick comments:
In `@shortcuts/wiki/wiki_node_create_test.go`:
- Around line 114-126: The test in wiki_node_create_test.go currently only
checks len(shortcuts) and a few commands; strengthen it by asserting the full
expected command list or at minimum add explicit checks for the newly added
commands: verify that shortcuts contains "+space-create", "+node-get", and
"+node-delete" (in addition to existing checks for "+move", "+node-create",
"+delete-space"), using the same pattern as the existing assertions against
shortcuts[n].Command so the test fails if any command is missing or out of
order.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5a211eba-1323-42a1-9667-4ef59fe458ee
📒 Files selected for processing (10)
shortcuts/wiki/shortcuts.goshortcuts/wiki/wiki_async_task.goshortcuts/wiki/wiki_delete.goshortcuts/wiki/wiki_node_create_test.goshortcuts/wiki/wiki_node_delete.goshortcuts/wiki/wiki_node_delete_test.goshortcuts/wiki/wiki_node_get.goshortcuts/wiki/wiki_node_get_test.goshortcuts/wiki/wiki_space_create.goshortcuts/wiki/wiki_space_create_test.go
liujinkun2025
force-pushed
the
feat/wiki-node-shortcuts
branch
from
May 15, 2026 08:47
f282650 to
eeda447
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
shortcuts/wiki/wiki_space_create.go (1)
108-119: ⚡ Quick winReuse the shared space-record formatter here.
This open-codes the flattened
spacefields even though the file already referencesparseWikiSpaceRecord. Composing the shared parser/formatter and then overlayingdescriptionwould keep+space-createaligned with the other wiki space outputs and avoid future drift.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/wiki/wiki_space_create.go` around lines 108 - 119, Replace the manual field extraction in wikiSpaceCreateOutput with a call to the shared parser/formatter parseWikiSpaceRecord(raw) and then overlay or set the "description" key from the raw map so the create output stays consistent with other wiki space outputs; specifically, inside wikiSpaceCreateOutput call parseWikiSpaceRecord(raw) to get the base map, copy/merge that into the returned map, and ensure "description" is taken from common.GetString(raw, "description") to override or preserve the caller-provided description.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@shortcuts/wiki/wiki_space_create.go`:
- Around line 108-119: Replace the manual field extraction in
wikiSpaceCreateOutput with a call to the shared parser/formatter
parseWikiSpaceRecord(raw) and then overlay or set the "description" key from the
raw map so the create output stays consistent with other wiki space outputs;
specifically, inside wikiSpaceCreateOutput call parseWikiSpaceRecord(raw) to get
the base map, copy/merge that into the returned map, and ensure "description" is
taken from common.GetString(raw, "description") to override or preserve the
caller-provided description.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2154a194-f9ac-466c-8175-f64a619eadf2
📒 Files selected for processing (11)
shortcuts/wiki/shortcuts.goshortcuts/wiki/wiki_async_task.goshortcuts/wiki/wiki_async_task_test.goshortcuts/wiki/wiki_delete.goshortcuts/wiki/wiki_node_create_test.goshortcuts/wiki/wiki_node_delete.goshortcuts/wiki/wiki_node_delete_test.goshortcuts/wiki/wiki_node_get.goshortcuts/wiki/wiki_node_get_test.goshortcuts/wiki/wiki_space_create.goshortcuts/wiki/wiki_space_create_test.go
✅ Files skipped from review due to trivial changes (1)
- shortcuts/wiki/wiki_node_create_test.go
🚧 Files skipped from review as they are similar to previous changes (8)
- shortcuts/wiki/shortcuts.go
- shortcuts/wiki/wiki_space_create_test.go
- shortcuts/wiki/wiki_node_get_test.go
- shortcuts/wiki/wiki_node_get.go
- shortcuts/wiki/wiki_delete.go
- shortcuts/wiki/wiki_async_task.go
- shortcuts/wiki/wiki_node_delete.go
- shortcuts/wiki/wiki_node_delete_test.go
4 tasks
liujinkun2025
force-pushed
the
feat/wiki-node-shortcuts
branch
from
May 18, 2026 04:09
eeda447 to
2cfd336
Compare
Collaborator
Author
Review follow-up (force-pushed amend
|
liujinkun2025
force-pushed
the
feat/wiki-node-shortcuts
branch
from
May 18, 2026 04:23
2cfd336 to
6c4b979
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-wiki/SKILL.md`:
- Around line 64-65: Add the missing nodes.delete API to the "### nodes" API
Resources list (so it appears alongside copy, create, and list) and add a
corresponding row in the Permissions table for nodes.delete with the required
scope; update the API Resources section (the "### nodes" block) to include
"delete" and add a permission-table entry for "nodes.delete" specifying the
proper scope string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 40b1b130-3339-4086-a3ae-b2101c51bf20
📒 Files selected for processing (18)
shortcuts/drive/drive_task_result.goshortcuts/drive/drive_task_result_test.goshortcuts/wiki/shortcuts.goshortcuts/wiki/wiki_async_task.goshortcuts/wiki/wiki_async_task_test.goshortcuts/wiki/wiki_delete.goshortcuts/wiki/wiki_delete_test.goshortcuts/wiki/wiki_node_create_test.goshortcuts/wiki/wiki_node_delete.goshortcuts/wiki/wiki_node_delete_test.goshortcuts/wiki/wiki_node_get.goshortcuts/wiki/wiki_node_get_test.goshortcuts/wiki/wiki_space_create.goshortcuts/wiki/wiki_space_create_test.goskills/lark-wiki/SKILL.mdskills/lark-wiki/references/lark-wiki-node-delete.mdskills/lark-wiki/references/lark-wiki-node-get.mdskills/lark-wiki/references/lark-wiki-space-create.md
💤 Files with no reviewable changes (1)
- shortcuts/wiki/wiki_node_create_test.go
✅ Files skipped from review due to trivial changes (2)
- skills/lark-wiki/references/lark-wiki-node-get.md
- skills/lark-wiki/references/lark-wiki-node-delete.md
🚧 Files skipped from review as they are similar to previous changes (12)
- shortcuts/wiki/wiki_space_create.go
- shortcuts/wiki/wiki_delete_test.go
- shortcuts/drive/drive_task_result_test.go
- shortcuts/wiki/wiki_async_task_test.go
- shortcuts/wiki/wiki_delete.go
- shortcuts/wiki/wiki_space_create_test.go
- shortcuts/wiki/wiki_node_get.go
- shortcuts/wiki/wiki_async_task.go
- shortcuts/wiki/wiki_node_delete_test.go
- shortcuts/wiki/wiki_node_get_test.go
- shortcuts/drive/drive_task_result.go
- shortcuts/wiki/wiki_node_delete.go
liujinkun2025
force-pushed
the
feat/wiki-node-shortcuts
branch
2 times, most recently
from
May 18, 2026 06:30
0f0d894 to
56328d3
Compare
Collaborator
Author
|
Proactive convergence (not a CodeRabbit ask): dropped the synthesized |
liujinkun2025
force-pushed
the
feat/wiki-node-shortcuts
branch
from
May 18, 2026 07:08
56328d3 to
69752e0
Compare
fangshuyu-768
left a comment
fangshuyu-768
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR — solid work overall. Left a few comments on things worth considering before merge. Summary of findings:
- [Medium]
wikiNodeGetURLObjTypesmap iteration — Go map order is non-deterministic; consider an ordered slice or a runtime prefix-conflict check. - [Low]
queryWikiDeleteNodeTaskvsparseWikiAsyncTaskStatus— duplicated logic; add a sync-maintenance note. - [Needs confirmation]
+space-createRisk level —writevshigh-risk-writefor an irreversible operation. - [Low]
looksLikeWikiNodeTokenheuristic — only checkswikprefix; worth documenting the assumption. - [Nitpick]
wikiSpaceCreateOutputnot reusingparseWikiSpaceRecord— risk of field drift. - [Low]
formatWikiTimestampuses local timezone — output varies by server timezone.
- +node-get: wrap wiki.spaces.get_node; accepts node_token, obj_token, or a Lark URL (URL path auto-infers obj_type); formatted output with creator / updated_at. No synthesized url — get_node returns none and a BuildResourceURL fallback is a non-canonical link that misleads in a read/confirm command (sibling read shortcuts omit it too) - +node-delete: wrap space.node delete; high-risk-write (--yes gated), async delete-node task polling, auto-resolves space_id via get_node when --space-id omitted, actionable hints for codes 131011 / 131003. The delete-node task result lives under the gateway's generic `simple_task_result` key (NOT `delete_node_result`) - +space-create: wrap spaces.create; user-only identity, --name required (no empty-name spaces), flattened space output, no url - factor the shared wiki async-task poll loop into wiki_async_task.go; preserve upstream Lark Detail.Code on poll exhaustion (no longer rebuilt via lossy ErrWithHint) - drive +task_result: add wiki_delete_node scenario so +node-delete's async-timeout next_command actually resolves - skill docs: reference pages for the 3 new shortcuts + SKILL.md shortcuts table (no raw nodes.delete API exists — it's shortcut-only, so it is intentionally absent from API Resources / permission table); drop the circular TestWikiShortcutsIncludeAllCommands change-detector Change-Id: I316f78290cec5bc50f80d629173e3bf2a35dd005
liujinkun2025
force-pushed
the
feat/wiki-node-shortcuts
branch
from
May 19, 2026 03:08
69752e0 to
7d8071f
Compare
fangshuyu-768
approved these changes
May 19, 2026
This was referenced May 21, 2026
3 tasks
tuxedomm
pushed a commit
to zhumiaoxin/cli
that referenced
this pull request
Jun 6, 2026
…arksuite#904) - +node-get: wrap wiki.spaces.get_node; accepts node_token, obj_token, or a Lark URL (URL path auto-infers obj_type); formatted output with creator / updated_at. No synthesized url — get_node returns none and a BuildResourceURL fallback is a non-canonical link that misleads in a read/confirm command (sibling read shortcuts omit it too) - +node-delete: wrap space.node delete; high-risk-write (--yes gated), async delete-node task polling, auto-resolves space_id via get_node when --space-id omitted, actionable hints for codes 131011 / 131003. The delete-node task result lives under the gateway's generic `simple_task_result` key (NOT `delete_node_result`) - +space-create: wrap spaces.create; user-only identity, --name required (no empty-name spaces), flattened space output, no url - factor the shared wiki async-task poll loop into wiki_async_task.go; preserve upstream Lark Detail.Code on poll exhaustion (no longer rebuilt via lossy ErrWithHint) - drive +task_result: add wiki_delete_node scenario so +node-delete's async-timeout next_command actually resolves - skill docs: reference pages for the 3 new shortcuts + SKILL.md shortcuts table (no raw nodes.delete API exists — it's shortcut-only, so it is intentionally absent from API Resources / permission table); drop the circular TestWikiShortcutsIncludeAllCommands change-detector Change-Id: I316f78290cec5bc50f80d629173e3bf2a35dd005
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills the wiki node/space CRUD gaps. Three new shortcuts plus a shared async-task helper:
wiki +node-get— wrapswiki.spaces.get_node. Accepts a rawnode_token/obj_tokenor a Lark URL (URL path auto-infersobj_type; conflicting explicit--obj-typeis rejected). Optional--space-idcross-check. Formatted output:title / obj_type / obj_token / node_token / space_id / parent_node_token / creator / updated_at / url.wiki +node-delete— wraps thespace.nodedelete API.high-risk-write(--yesgated), bounded asyncdelete_nodetask polling, auto-resolvesspace_idviaget_nodewhen--space-idis omitted,--include-childrendefaults totrue. Maps Lark codes131011(UI-approval required) and131003(subtree too large) to actionable hints; other codes pass through with the original code preserved.wiki +space-create— wrapsspaces.create. User-only identity (the API rejects tenant/bot tokens; frameworkCheckIdentityenforces it).--namerequired (no empty-name spaces),--descriptionoptional. Flattened space output, nourl(the API returns none and there is no space-home URL builder).wiki_async_task.go(pollWikiAsyncTask/parseWikiAsyncTaskStatus/wikiAsyncTaskStatus).+delete-spacenow delegates to it via thin wrappers — no behavior change, ~110 lines of duplication removed.Also renames the originally-proposed
+get-nodeto+node-getfor consistency with the+node-*family.Risk-level note:
spaces.createcarriesdanger:truein the registry, but that flag only drives thelark-cli schemabrowser's red[danger]tag — it is not a runtime confirmation gate (onlyrisk:high-risk-writeis). The raw API runs without--yestoday, so+space-createatRisk:writeis runtime-consistent; a help Tip surfaces the danger flag and points to+delete-spacefor undo.Test plan
go test ./shortcuts/...(and full suite excludingtests/cli_e2e) greengofmt -lclean,go vet ./shortcuts/wiki/...clean,./build.shOK--yesgating, bot-identity rejection, output flattening--help,--dry-run, validation failures, identity rejection for each shortcutgolangci-lintnot run (not installed in dev env) — please confirm in CItests/cli_e2e/wikinot run locally (hits real Feishu) — verify in CI/stagingSummary by CodeRabbit
New Features
Improvements
Tests
Documentation