Skip to content

Add Deploy as Change Event#3997

Merged
bjester merged 11 commits intolearningequality:unstablefrom
ozer550:ActivationChangeEventBackend
Apr 13, 2023
Merged

Add Deploy as Change Event#3997
bjester merged 11 commits intolearningequality:unstablefrom
ozer550:ActivationChangeEventBackend

Conversation

@ozer550
Copy link
Copy Markdown
Member

@ozer550 ozer550 commented Mar 21, 2023

Summary

Description of the change(s) you made

This PR converts synchronous calls of deployment of ricecooker channels into an change event operation.

Closes #3884.
Closes #3380.
Closes #2928.

Manual verification steps performed

  1. Created tests for the changes.
  2. Ran all the tests locally.

Comments

@vkWeb is working with the frontend part and required modifications can be done to adapt the information coming from the frontend.

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@ozer550 ozer550 requested review from bjester and vkWeb March 21, 2023 16:52
@vkWeb vkWeb marked this pull request as draft March 22, 2023 10:42
@vkWeb vkWeb changed the title Add Deploy Event Backend Add Deploy as Change Event Mar 22, 2023
@vkWeb vkWeb marked this pull request as ready for review April 5, 2023 10:42
@vkWeb vkWeb marked this pull request as draft April 5, 2023 10:55
@vkWeb vkWeb marked this pull request as ready for review April 6, 2023 13:15
Comment thread contentcuration/contentcuration/frontend/shared/data/resources.js
@vkWeb
Copy link
Copy Markdown
Member

vkWeb commented Apr 9, 2023

@ozer550 now you can remove the old activate_channel function from the backend.

@bjester sir frontend tests fix will be done soon.

@vkWeb vkWeb marked this pull request as draft April 10, 2023 19:03
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue, but overall looks great. Please see my comment

Comment thread contentcuration/contentcuration/viewsets/channel.py Outdated
@bjester bjester added TAG: performance changelog Needs to be added to the changelog (remove once added) labels Apr 12, 2023
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💯

@bjester bjester merged commit 2fd01d1 into learningequality:unstable Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants