Skip to content

Add ClipBox::content_must_fill#1630

Merged
cmyr merged 1 commit intomasterfrom
clipbox-must-fill
Mar 8, 2021
Merged

Add ClipBox::content_must_fill#1630
cmyr merged 1 commit intomasterfrom
clipbox-must-fill

Conversation

@cmyr
Copy link
Member

@cmyr cmyr commented Mar 1, 2021

This adds a flag that forces the child to be at least as large
as the parent, which is a common behaviour for scroll views.

I'm playing around with using this with the textbox, instead
of having our own manual scroll implementation.


  • I don't love this name
  • There's an argument that this should be per-axis, but I'm not really sure that would be very useful?

@cmyr cmyr force-pushed the clipbox-must-fill branch from 33d5edd to 56c8fbd Compare March 1, 2021 17:07
Base automatically changed from clipbox-fixup to master March 1, 2021 19:19
This adds a flag that forces the child to be at least as large
as the parent, which is a common behaviour for scroll views.

I'm playing around with using this with the textbox, instead
of having our own manual scroll implementation.
@cmyr
Copy link
Member Author

cmyr commented Mar 8, 2021

@jneem any thoughts on the name for this?

@jneem
Copy link
Member

jneem commented Mar 8, 2021

I don't love it, but I don't have a better suggestion. And at least it's consistent with Flex...

@cmyr
Copy link
Member Author

cmyr commented Mar 8, 2021

yea I can't think of anything better either. 😒

@cmyr cmyr merged commit 28a5a90 into master Mar 8, 2021
@cmyr cmyr deleted the clipbox-must-fill branch March 8, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants