Conversation
This adds a flag that forces the child to be at least as large as the parent, which is a common behaviour for scroll views. I'm playing around with using this with the textbox, instead of having our own manual scroll implementation.
Member
Author
|
@jneem @ForLoveOfCats either of you have any concerns with this? |
ForLoveOfCats
approved these changes
Mar 7, 2021
Collaborator
ForLoveOfCats
left a comment
ForLoveOfCats
left a comment
There was a problem hiding this comment.
I have no objections. Perhaps they should get a changelog entry where appropriate?
Member
Author
|
Oh good call I keep forgetting about the changelog 😬 |
These make it possible to configure a few more aspects of the scrollview's behaviour after it is created. This will be used for upcoming changes to the textbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These make it possible to configure a few more aspects of the
scrollview's behaviour after it is created.
This will be used for upcoming changes to the textbox.
This also relaxes the type constraints required for some methods.
based off of #1630