Windows: fix the raw-win-handle feature#2233
Closed
sidit77 wants to merge 2 commits intolinebender:masterfrom
Closed
Windows: fix the raw-win-handle feature#2233sidit77 wants to merge 2 commits intolinebender:masterfrom
sidit77 wants to merge 2 commits intolinebender:masterfrom
Conversation
jneem
requested changes
Jul 31, 2022
Member
jneem
left a comment
jneem
left a comment
There was a problem hiding this comment.
Thanks! It looks like we really do need to be running this feature in CI -- I'll try to make a PR for that tomorrow. In the meantime, just a minor quibble about the comment...
| as *mut core::ffi::c_void | ||
| }, | ||
| ..WindowsHandle::empty() | ||
| // Using empty + set fields instead Win32Handle{...} to shut up a unexplainable compiler error |
Member
There was a problem hiding this comment.
I wouldn't say it's "unexplainable." Win32Handle is marked as #[non_exhaustive], which is explained here
Member
|
Thanks again for the PR! But since #2238 fixes this and also bumps raw-window-handle to 0.5, I'm going to close this one and merge that one instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raw-win-handle feature is currently broken on windows because it was not properly updated to
raw-window-handle0.4 when that dependency was bumped.