Update raw window handle and fix raw-win-handle feature#2238
Merged
jneem merged 3 commits intolinebender:masterfrom Aug 2, 2022
Merged
Update raw window handle and fix raw-win-handle feature#2238jneem merged 3 commits intolinebender:masterfrom
jneem merged 3 commits intolinebender:masterfrom
Conversation
jneem
requested changes
Aug 1, 2022
Member
jneem
left a comment
jneem
left a comment
There was a problem hiding this comment.
Thanks for the PR! You'll need to appease the CI before it will let us merge, though.
Co-authored-by: jneem <joeneeman@gmail.com>
jneem
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2237, resolves #2225
Updates raw-window-handle from 0.4.2 to 0.5.0 and fixes the feature which is currently broken on all platforms.
I tested it on all platforms except macOS.
Small note: for the
x11backend, the xcb connection was previously stored in theRawWindowHandle, but since 0.5.0 decoupled theWindowHandles andDisplayHandles, it is no longer present. It was not used anywhere by druid however.