make image formats optional via features#342
Merged
cmyr merged 3 commits intolinebender:masterfrom Oct 21, 2020
Merged
Conversation
cmyr
approved these changes
Oct 21, 2020
Member
cmyr
left a comment
There was a problem hiding this comment.
Okay, lets give this a shot. I was a little worried it would over-complicate things but we can always revisit if that ends up being the case.
Contributor
Author
|
I don't like it either, but as it is the default features of |
Member
|
@JAicewizard sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to druid #1305, this PR makes piet default to no supported image formats, and allow adding support via features.
If only
pngandjpegare required this cuts build times by 55% on my machine, and even with rayon build times are 35% less (for just piet).These build times are stacking, so the hdr build time also include png and jpeg...
But you can still clearly see that it is worth not having some of these, especially for the more obscure ones like everything after webp.
I have not benchmarked the impact on binary size, but I could make a small example program to see the impact on that.