Skip to content

Optional image features#1340

Merged
jneem merged 5 commits intolinebender:masterfrom
JAicewizard:optional_image_features
Oct 23, 2020
Merged

Optional image features#1340
jneem merged 5 commits intolinebender:masterfrom
JAicewizard:optional_image_features

Conversation

@JAicewizard
Copy link
Contributor

@JAicewizard JAicewizard commented Oct 22, 2020

This is a follow up to linebender/piet#342.
For my simple use-case (https://martens-icons-website.netlify.app/) the WASM binary shrunk from 1.4MiB -> 0.8MiB uncompressed, making this a 60% WASM binary savings for this simple app not needing any image format.
fixed #1305

@JAicewizard
Copy link
Contributor Author

I just wanted to say that locally I hit a clippy bug in one of the tests where clippy crashes, I might report that as a bug if it happens here too

Copy link
Member

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jneem jneem merged commit 62af6c4 into linebender:master Oct 23, 2020
@cmyr
Copy link
Member

cmyr commented Oct 26, 2020

@JAicewizard was your crash this one? If it's not you should definitely consider reporting it back to clippy. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minimise features imported from image crate.

3 participants