Fix start-workload.sh#62
Closed
sunchao wants to merge 1 commit into
Closed
Conversation
This fixes two issues encountered when running start-workload.sh: 1. The README description is incorrect. It should use `=` for config key & value for auditreplay configs. 2. The mapper_class_name value doesn't work - it should look under com.linkedin.dynamometer.workloadgenerator.audit instead of com.linkedin.dynamometer.workloadgenerator
xkrogen
requested changes
Aug 29, 2018
| private Class<? extends WorkloadMapper> getMapperClass(String className) throws ClassNotFoundException { | ||
| if (!className.contains(".")) { | ||
| className = WorkloadDriver.class.getPackage().getName() + "." + className; | ||
| className = WorkloadDriver.class.getPackage().getName() + ".audit." + className; |
Collaborator
There was a problem hiding this comment.
This will fix things for the AuditReplayMapper, but break things for CreateFileMapper... I created the audit package to group together related classes, but didn't realize I broke the assumption that all mapper classes would be in the same package. I was trying to be clever here, but maybe it would be better to just maintain a static mapping of short name -> class.
This was referenced Feb 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues encountered when running start-workload.sh:
=forconfig key & value for auditreplay configs.
com.linkedin.dynamometer.workloadgenerator.audit instead of
com.linkedin.dynamometer.workloadgenerator
Fixes #60 .