Skip to content

Fix start-workload.sh #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunchao wants to merge 1 commit into from
Closed

Fix start-workload.sh #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ via logging when the Dyno-NN has exited safemode and is ready for use.
At this point, a workload job (map-only MapReduce job) can be launched, e.g.:
```
./bin/start-workload.sh
-Dauditreplay.input-path hdfs:///dyno/audit_logs/
-Dauditreplay.num-threads 50
-Dauditreplay.input-path=hdfs:///dyno/audit_logs/
-Dauditreplay.num-threads=50
-nn_uri hdfs://namenode_address:port/
-start_time_offset 5m
-mapper_class_name AuditReplayMapper
Expand Down
2 changes: 1 addition & 1 deletion ...ter-workload/src/main/java/com/linkedin/dynamometer/workloadgenerator/WorkloadDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public static void main(String[] args) throws Exception {

private Class<? extends WorkloadMapper> getMapperClass(String className) throws ClassNotFoundException {
if (!className.contains(".")) {
className = WorkloadDriver.class.getPackage().getName() + "." + className;
className = WorkloadDriver.class.getPackage().getName() + ".audit." + className;

@xkrogen xkrogen Aug 29, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix things for the AuditReplayMapper, but break things for CreateFileMapper... I created the audit package to group together related classes, but didn't realize I broke the assumption that all mapper classes would be in the same package. I was trying to be clever here, but maybe it would be better to just maintain a static mapping of short name -> class.

}
Class<?> mapperClass = getConf().getClassByName(className);
if (!WorkloadMapper.class.isAssignableFrom(mapperClass)) {
Expand Down