Skip to content
This repository was archived by the owner on Jul 15, 2026. It is now read-only.

sync: from linuxdeepin/dtkcore#57

Merged
kegechen merged 1 commit into
masterfrom
sync-pr-423-nosync
Jun 18, 2024
Merged

sync: from linuxdeepin/dtkcore#57
kegechen merged 1 commit into
masterfrom
sync-pr-423-nosync

Conversation

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#423

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#423
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

关键摘要:

  • 在else if语句中,条件判断应该使用==而不是!=来避免潜在的逻辑错误。
  • 代码中没有对m_dsgConfigm_fallbackConfig进行空指针检查,可能会导致未定义行为。

是否建议立即修改:

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
kegechen merged commit d66066b into master Jun 18, 2024
@kegechen
kegechen deleted the sync-pr-423-nosync branch June 18, 2024 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants