Skip to content

chore: add nullptr check#423

Merged
kegechen merged 1 commit into
linuxdeepin:masterfrom
kegechen:nullptr
May 30, 2024
Merged

chore: add nullptr check#423
kegechen merged 1 commit into
linuxdeepin:masterfrom
kegechen:nullptr

Conversation

@kegechen

Copy link
Copy Markdown
Contributor

nullptr check

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • 在else if语句中,条件判断逻辑可能存在问题。原代码中是检查m_fallbackConfig是否存在,而修改后的代码是检查m_dsgConfig是否存在,这可能会导致不同的行为。
  • 代码修改后,如果m_dsgConfig存在但未设置RULES_KEY的值,var可能会是nullptr,这可能不是预期的行为。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 30, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#423
@deepin-bot

deepin-bot Bot commented May 30, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants