Skip to content
This repository was archived by the owner on Jul 15, 2026. It is now read-only.

sync: from linuxdeepin/dtkdeclarative - #129

Closed
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-363-nosync
Closed

sync: from linuxdeepin/dtkdeclarative#129
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-363-nosync

Conversation

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#363

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
deepin-ci-robot force-pushed the sync-pr-363-nosync branch 5 times, most recently from b9fba05 to 1f866ce Compare July 25, 2024 03:31
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#363
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

关键摘要:

  • ControlGroupControlGroupItem组件中,使用了Loader组件来加载背景,但背景颜色设置为DS.Style.highlightPanel.background,这可能是一个错误,应该使用DS.Style.itemDelegate.normalColor
  • ControlGroup组件中的D.DciIcon组件的旋转属性rotation的默认值应该是-90,而不是0
  • ControlGroup组件中的Timer对象timer没有在代码中看到使用,应该确认是否有遗漏或移除。
  • ControlGroupItem组件中的Behavior对象on yon opacity的动画效果应该设置为Easing.Expo以获得更平滑的过渡效果。
  • ControlGroupItem组件中的yopacity属性的行为动画应该使用NumberAnimation而不是PropertyChanges
  • ControlGroupControlGroupItem组件中的inset属性在RowLayoutLabel中使用了不同的值,应该保持一致性。
  • ControlGroup组件中的onIsExpandedChanged槽函数在处理子项展开状态时,使用了循环而不是递归,这可能会导致性能问题。
  • ControlGroup组件中的timeout函数在处理展开状态时,使用了硬编码的indexitemLayout.children.length,这可能会导致在处理大量子项时出现错误。
  • ControlGroup组件中的delay函数在处理动画时,使用了timer.intervaltimer.repeat,但没有看到timer.triggered的连接,这可能会导致动画无法正确启动。

是否建议立即修改:

@deepin-bot

deepin-bot Bot commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #148

@kegechen kegechen added the hold-on should not merge now label Sep 11, 2024
@kegechen

Copy link
Copy Markdown
Contributor

too many rebot prs

@kegechen kegechen closed this Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hold-on should not merge now

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants