Skip to content

chore: add ControlGroup - #363

Merged
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:expanding
Jul 25, 2024
Merged

chore: add ControlGroup#363
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:expanding

Conversation

@FeiWang1119

Copy link
Copy Markdown

add ControlGroup

Log:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 18, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#363
@FeiWang1119
FeiWang1119 changed the base branch from master to dev/animation July 18, 2024 11:53
@deepin-bot

deepin-bot Bot commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 19, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#363
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 19, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#363
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#363
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#363
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#363
add ControlGroup

Log:
@kegechen
kegechen merged commit fe06a05 into linuxdeepin:dev/animation Jul 25, 2024
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#363
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • ControlGroupControlGroupItem组件中,使用了Timer来控制子项的展开和折叠动画,这可能导致性能问题,特别是在频繁切换展开状态时。建议使用更加高效的方式来处理动画。
  • ControlGroup组件中的timeout函数可能会导致无限循环,如果index超过了itemLayout.children.length,应该进行适当的处理。
  • delay函数在timeout函数中被使用,但是没有看到相关的注释说明其用途,建议添加注释以提高代码的可读性。
  • ControlGroup组件中的titlemouseAreaonPressedonReleased事件处理中,直接修改了title的状态,这可能会导致逻辑错误。应该使用ControlGroupItem的状态来控制展开和折叠。
  • ControlGroup组件中的title组件的states属性中定义了状态切换动画,但是没有看到对应的PropertyChanges来更新inset属性,这可能会导致title组件的边框宽度无法正确显示。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants