Skip to content
This repository was archived by the owner on Jul 15, 2026. It is now read-only.

sync: from linuxdeepin/dtkdeclarative - #130

Closed
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-364-nosync
Closed

sync: from linuxdeepin/dtkdeclarative#130
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-364-nosync

Conversation

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#364

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
deepin-ci-robot force-pushed the sync-pr-364-nosync branch 3 times, most recently from ceffd8a to 824b419 Compare July 25, 2024 03:39
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#364
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

关键摘要:

  • ControlGroupItemRectangleButton组件中,radius属性被设置为10,但在使用dtkInWindowBlur时,背景无法正确显示。
  • ControlGroupTimer组件中,interval属性被设置为400 / (itemLayout.children.length),这可能导致在某些情况下,动画效果不流畅。
  • ParallelAnimation中,running属性被多次设置,这可能不是必要的,可以考虑简化动画逻辑。
  • MenuItemLoader组件中,active属性被设置为control.down || control.highlighted,这可能导致在某些情况下,背景颜色不会正确应用。
  • MenutopPadding属性中,硬编码的值6可能不适用于所有情况,应该考虑使用更灵活的解决方案。
  • MessageManagerensureLayout函数中,spacing属性被设置为0,这可能会影响布局的视觉效果,应该确保这一改动不会对现有布局产生负面影响。
  • ControlGroupItemComponent.onCompleted中添加了console.log,这可能不是必要的,应该评估是否有更好的方式来调试或监控组件的加载过程。

是否建议立即修改:

  • 应该立即修复ControlGroupItem中的radius属性问题,以确保背景正确显示。
  • 需要重新审视ControlGroup中的Timer组件的逻辑,确保动画效果流畅。
  • 应该清理ParallelAnimation中的running属性设置,避免不必要的重复设置。
  • 需要评估MenuItem中的Loader组件的active属性设置,确保背景颜色正确应用。
  • 应该重新考虑Menu中的topPadding硬编码值,使用更灵活的解决方案。
  • 需要确保ensureLayout函数的spacing改动不会对现有布局产生负面影响。
  • 应该评估Component.onCompleted中的console.log是否真的必要,寻找更合适的调试和监控方式。

@deepin-bot

deepin-bot Bot commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #148

@kegechen kegechen added the hold-on should not merge now label Sep 11, 2024
@kegechen

Copy link
Copy Markdown
Contributor

too many rebot prs

@kegechen kegechen closed this Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hold-on should not merge now

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants