Skip to content

chore: add the animation for FloatingMessage - #364

Merged
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:message
Jul 25, 2024
Merged

chore: add the animation for FloatingMessage#364
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:message

Conversation

@FeiWang1119

Copy link
Copy Markdown

add the animation for FloatingMessage

Log:

@FeiWang1119
FeiWang1119 changed the base branch from master to dev/animation July 23, 2024 12:40
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 23, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#364
@deepin-bot

deepin-bot Bot commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 24, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#364
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 24, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#364
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#364
add the animation for FloatingMessage

Log:
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#364
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • D.FloatingMessageContaineronClicked槽函数中,新增了floatingPanel.state = "small",但没有相应的状态变化或动画处理。
  • ParallelAnimation中使用了running属性来控制动画的播放,这可能会导致动画的逻辑不够清晰。
  • TimerNumberAnimation的使用可能会导致界面在动画过程中闪烁或闪烁。
  • console.logTimer中用于调试,但在生产环境中应该避免使用。
  • duration: 4000D.FloatingMessageContainer中定义了消息的显示时间,但没有考虑用户交互(如点击关闭按钮)来提前关闭消息。
  • Component.onCompletedD.FloatingMessageContainer中用于触发timer的初始化,但没有考虑到timer可能已经在其他地方被初始化。
  • bottomMargin的值在Column组件中从10调整到20,但没有提供上下文说明为什么需要这样的调整。
  • Component.onCompleted中的console.log在生产环境中应该被移除或替换为更合适的日志记录方式。

是否建议立即修改:

@kegechen
kegechen merged commit bee7ec4 into linuxdeepin:dev/animation Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants