Skip to content
This repository was archived by the owner on Jul 15, 2026. It is now read-only.

sync: from linuxdeepin/dtkwidget - #98

Closed
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-621-nosync
Closed

sync: from linuxdeepin/dtkwidget#98
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-621-nosync

Conversation

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#621

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
deepin-ci-robot force-pushed the sync-pr-621-nosync branch 2 times, most recently from cd4fe3c to 99df307 Compare November 23, 2024 07:39
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#621
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

关键摘要:

  • DDialogPrivate::_q_onButtonClicked函数中,clickedButtonIndex的赋值位置被移动,可能会影响其他依赖于clickedButtonIndex的代码逻辑。
  • DDialog::exec函数中,移除了关于clickedButtonIndex的信号槽连接,这可能会影响在exec执行期间按钮点击事件的正确处理。
  • DDialog::closeEvent函数中,done函数的参数被修改为d->clickedButtonIndex,这可能会改变关闭对话框时的行为。
  • DTitlebar::setVisible函数中,connect函数的信号和槽参数被修改,这可能会影响按钮点击事件的处理方式。

是否建议立即修改:

  • 需要确认clickedButtonIndex的赋值位置更改是否会影响其他部分的代码逻辑,并确保这一更改不会引入新的错误。
  • 应该重新评估exec函数中移除信号槽连接的决定,以确保按钮点击事件能够正确处理。
  • closeEvent函数中done函数参数的更改需要仔细测试,以确保关闭对话框时的行为符合预期。
  • DTitlebar::setVisible函数中的connect函数参数更改也需要进行测试,以确保按钮点击事件的处理方式正确。

@deepin-bot

deepin-bot Bot commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.0.24
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #100

@deepin-bot

deepin-bot Bot commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.0.24.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #102

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants