Skip to content

fix: exit animation of the application disappeared in treeland#621

Closed
FeiWang1119 wants to merge 1 commit into
linuxdeepin:masterfrom
FeiWang1119:master
Closed

fix: exit animation of the application disappeared in treeland#621
FeiWang1119 wants to merge 1 commit into
linuxdeepin:masterfrom
FeiWang1119:master

Conversation

@FeiWang1119

Copy link
Copy Markdown
Contributor

When clicking the close button, call the widget::close.
Modify that calling dapplication::quit is the same as clicking the option to exit

Log:

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Nov 23, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#621
@FeiWang1119
FeiWang1119 force-pushed the master branch 2 times, most recently from 74a8cb0 to fb82576 Compare November 23, 2024 07:37
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Nov 23, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#621
When clicking the close button, call the widget::close.
Modify that calling dapplication::quit is the same as clicking the option to exit

Log:
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Nov 23, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#621
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • connect 函数中的信号和槽连接方式可能不正确,应该使用 SIGNALSLOT 宏来连接信号和槽。
  • d->closeButton 的信号和槽连接可能需要确认 clicked(bool) 是否是正确的信号,通常按钮的点击信号是 clicked() 而不是 clicked(bool)

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Nov 23, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#621
Comment thread src/widgets/dtitlebar.cpp
connect(this, SIGNAL(doubleClicked()), this, SLOT(_q_toggleWindowState()), Qt::UniqueConnection);
connect(d->minButton, SIGNAL(clicked()), this, SLOT(_q_showMinimized()), Qt::UniqueConnection);
connect(d->closeButton, &DWindowCloseButton::clicked, d->targetWindow(), &QWidget::close, Qt::UniqueConnection);
connect(d->closeButton, SIGNAL(clicked(bool)), this, SLOT(_q_quitActionTriggered()), Qt::UniqueConnection);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

关闭按钮表示退出应用?那对于多窗口的应用是不是有问题呀,像终端这种,关闭一个终端就退出了终端应用了,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类似终端,文本编辑器都会截获退出事件做处理.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是要看看具体原因,是根据什么决定是否有动画? 退出码? 还是什么 @justforlxz

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepin-bot

deepin-bot Bot commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.7.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #623

@FeiWang1119 FeiWang1119 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants