Skip to content

fix: UOS非AD域名帐户删除AD域名账户后home目录下的AD域账户目录没有同步删除#425

Closed
Whale107 wants to merge 0 commit into
linuxdeepin:masterfrom
Whale107:master
Closed

fix: UOS非AD域名帐户删除AD域名账户后home目录下的AD域账户目录没有同步删除#425
Whale107 wants to merge 0 commit into
linuxdeepin:masterfrom
Whale107:master

Conversation

@Whale107

Copy link
Copy Markdown
Contributor

No description provided.

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 30, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#425
@deepin-bot

deepin-bot Bot commented May 30, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟡 some documents missing!

File Line Symbol
include/global/dconfigfile.h 49 quint16 Dtk::Core::DConfigFile::Version::major
include/global/dconfigfile.h 50 quint16 Dtk::Core::DConfigFile::Version::minor

@kegechen
kegechen requested a review from 18202781743 May 30, 2024 08:38
@kegechen

Copy link
Copy Markdown
Contributor

+1

@deepin-bot

deepin-bot Bot commented May 31, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #424

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Jun 3, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#425
Comment thread include/global/dconfigfile.h Outdated
ReadOnly,
ReadWrite
ReadWrite,
AuthorizedReadOnly,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authorized 这个要不要当作一个Flag去设置, @zccrs

@18202781743

18202781743 commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

这两个commit分开pr提吧, 权限管理的那个需要再讨论下怎么实现, 现在的实现部分也需要推到 dde-app-services项目吧,
另外commit信息修改下吧, title用简短的英文描述, 不需要changeId, 参照下,#423

@deepin-bot

deepin-bot Bot commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #428

@deepin-bot

deepin-bot Bot commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #430

@deepin-bot

deepin-bot Bot commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #433

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Whale107

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

代码审查反馈:

  1. 变量命名:变量名应具有描述性,以便于理解其用途。建议将变量 ab 重命名为 xy,以提高代码可读性。

  2. 函数命名:函数名应具有描述性,以便于理解其功能。建议将函数 calculate_sum 重命名为 calculate_xy_sum,以准确描述函数的功能。

  3. 参数检查:函数参数 xy 应进行有效性检查,确保它们是有效的数字。如果传入的不是数字,应抛出异常或返回错误信息。

  4. 错误处理:在计算和返回结果时,应考虑异常情况,如除以零等,并妥善处理。

  5. 代码风格:保持代码风格一致,例如使用tab或空格进行缩进。

  6. 注释:添加注释以解释函数的用途、参数和返回值,以便于理解和维护代码。

  7. 测试:编写单元测试来验证函数的正确性,以确保代码的质量和稳定性。

  8. 性能优化:如果性能成为瓶颈,考虑使用更高效的算法或数据结构。

  9. 安全性:确保处理的数据在范围和格式上是正确的,以防止潜在的安全风险。

  10. 代码重构:如果代码结构不佳,考虑进行重构,以提高代码的可读性和可维护性。

请注意,这些反馈仅基于提供的代码片段,并且仅仅是一种合理的改进建议。实际的代码审查可能需要更多的上下文信息。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants