Skip to content

fix: icon size changed on paletteChanged - #379

Merged
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
kegechen:iconSize
Aug 19, 2024
Merged

fix: icon size changed on paletteChanged#379
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
kegechen:iconSize

Conversation

@kegechen

Copy link
Copy Markdown
Contributor

只在初始化和 sourceSizeChanged 时更新图标大小
防止出现 dpr > 1.0 时未设置 sourceSize 的 item 在 updatePlayer 时图标一直放大 没有设置 sourceSize 会根据图片大小去 match dci 中的图标大小

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 15, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#379
@kegechen

Copy link
Copy Markdown
Contributor Author

see #376

@deepin-bot

deepin-bot Bot commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

只在初始化和 sourceSizeChanged 时更新图标大小
防止出现 dpr > 1.0 时未设置 sourceSize 的 item 在 updatePlayer 时图标一直放大
没有设置 sourceSize 会根据图片大小去 match dci 中的图标大小
@kegechen
kegechen merged commit 7024856 into linuxdeepin:dev/animation Aug 19, 2024
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • updatePlayerIconSize()函数调用后没有检查返回值,可能会导致未处理的初始化错误。
  • updatePlayerIconSize()函数调用可能依赖于sourceSizeChanged信号,但当前的调用顺序没有反映这种依赖关系。
  • 注释中的“只在初始化和 sourceSizeChanged 时更新图标大小”描述可能与实际的代码逻辑不一致,需要确认是否所有相关信号都已经正确连接。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 19, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants