Skip to content

fix: icon size changed on paletteChanged #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kegechen merged 1 commit into from
Aug 19, 2024
Merged

fix: icon size changed on paletteChanged #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/private/dquickdciiconimage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ void DQuickDciIconImageItemPrivate::updatePlayer()
QObject::connect(parentPriv->imageItem, &DQuickIconImage::sourceSizeChanged, player, [this](){
updatePlayerIconSize();
});

// 只在初始化和 sourceSizeChanged 时更新图标大小
// 防止出现 dpr > 1.0 时未设置 sourceSize 的 item 在 updatePlayer 时图标一直放大
updatePlayerIconSize();
}

QString iconPath = findDciIconPath(parentPriv->imageItem->name(), appIconThemeName());
Expand All @@ -155,8 +159,6 @@ void DQuickDciIconImageItemPrivate::updatePlayer()

player->setPalette(palette);

updatePlayerIconSize();

player->setDevicePixelRatio(devicePixelRatio);
}

Expand Down