Skip to content

fix: app crashed when InWindowBlur switching frequently - #396

Closed
18202781743 wants to merge 1 commit into
linuxdeepin:masterfrom
18202781743:fix
Closed

fix: app crashed when InWindowBlur switching frequently#396
18202781743 wants to merge 1 commit into
linuxdeepin:masterfrom
18202781743:fix

Conversation

@18202781743

Copy link
Copy Markdown
Contributor

Data maybe deleted in CleanJob, but RhiNode also have the invalide
pointer by the texture variable.
We use dataList whether contains the Data to judge it is valid.

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743
18202781743 requested a review from zccrs September 18, 2024 06:14
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 18, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#396
Data maybe deleted in CleanJob, but RhiNode also have the invalide
pointer by the texture variable.
We use dataList whether contains the Data to judge it is valid.
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • isValidData 函数的命名不够明确,建议使用更具描述性的名称,如 isDataValid
  • isValidData 函数的实现依赖于 dataList,但当前的实现没有反映这种依赖关系。
  • isValidData 函数的返回类型是 bool,但实际上它检查的是数据是否存在于列表中。建议将函数命名为 containsData 或者 doesDataExist,以更准确地描述其功能。
  • resolve 函数中,对 data 的检查被移动到了 isValidData 函数之前,这可能会改变原有的逻辑。需要确认这是否是预期的行为。
  • release 函数的调用被移到了 isValidData 函数之后,这可能会导致在数据无效时过早地释放数据。需要确保这是否是正确的做法。
  • oldManagerRhiNode 类中的使用看起来与 DataManager 类中的 manager 重复,可能存在命名冲突。
  • sgTexture()->setTexture(nullptr); 调用可能依赖于 oldManager 的结果,但当前的调用顺序没有反映这种依赖关系。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 18, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#396
@18202781743

18202781743 commented Sep 19, 2024

Copy link
Copy Markdown
Contributor Author

#378 已修复, #397 中带入到master分支,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants