Skip to content

fix: app crashed when InWindowBlur switching frequently #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
18202781743 wants to merge 1 commit into from
Closed

fix: app crashed when InWindowBlur switching frequently #396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/private/dbackdropnode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,17 +157,22 @@ class Q_DECL_HIDDEN DataManager : public DataManagerBase
}
}

bool isValidData(const Data *data) const {
return dataList.contains(data);
}

inline QQuickWindow *owner() const {
return static_cast<QQuickWindow*>(parent());
}

Data *resolve(Data *data, DataKeys&&... keys) {
if (data && get()->check(data->data, std::forward<DataKeys>(keys)...)
&& dataList.contains(data)) {
return data;
if (isValidData(data)) {
if (data && get()->check(data->data, std::forward<DataKeys>(keys)...)) {
return data;
}
if (data)
release(data);
}
if (data)
release(data);

for (auto data : dataList) {
if (get()->check(data->data, std::forward<DataKeys>(keys)...)) {
Expand Down Expand Up @@ -706,7 +711,7 @@ class Q_DECL_HIDDEN RhiNode : public DBackdropNode {

if (oldManager != manager) {
sgTexture()->setTexture(nullptr);
if (oldManager && texture)
if (oldManager && oldManager->isValidData(texture))
oldManager->release(texture);
}

Expand Down