fix: build error on Windows#400
Open
kt286 wants to merge 3 commits into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kt286 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Hi @kt286. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1520,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
2 similar comments
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1520,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1520,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
kt286
force-pushed
the
fix/build_on_msys2
branch
from
July 15, 2026 06:47
d8a077b to
1403e97
Compare
Contributor
|
Warning
详情 {
"export": {
"dtkgui.cmake": {
"b": [
" set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
]
}
}
} |
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1520,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
kt286
force-pushed
the
fix/build_on_msys2
branch
from
July 16, 2026 04:45
1403e97 to
20ebe00
Compare
Contributor
|
Warning
详情 {
"export": {
"dtkgui.cmake": {
"b": [
" set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
]
}
}
} |
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1526,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
Contributor
|
Warning
详情 {
"export": {
"dtkgui.cmake": {
"b": [
" set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
]
}
}
} |
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1526,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
Contributor
|
TAG Bot New tag: 6.7.46 |
- Guard Linux-only dependencies (WaylandClient, XCB, Treeland, librsvg, DConfig) behind platform checks to avoid build failures on Windows - Add LIBDTKGUISHARED_EXPORT macro with proper dllexport/dllimport for Windows, replacing Q_GUI_EXPORT and LIBDTKCORESHARED_EXPORT - Export all symbols on MinGW via --export-all-symbols linker flag - Wrap DBus calls, XCB headers, and dde-kwin-debug with Q_OS_UNIX/Q_OS_LINUX - Provide stub implementations for DPlatformWindowInterface blur and no-titlebar methods on Windows - Make librsvg optional via DTK_DISABLE_LIBRSVG - Update copyright years to 2026
kt286
force-pushed
the
fix/build_on_msys2
branch
from
July 17, 2026 03:12
a700a8e to
afae8c2
Compare
Contributor
|
Warning
详情 {
"export": {
"dtkgui.cmake": {
"b": [
" set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
]
}
}
} |
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1511,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
…ences on Linux dsvgrenderer.cpp checks #ifdef Q_OS_LINUX before including any Qt header, so the Q_OS_LINUX macro (defined in qglobal.h) is never evaluated, causing the entire file to be preprocessed away and leaving DSvgRenderer symbols undefined at link time.
Contributor
|
Warning
详情 {
"export": {
"dtkgui.cmake": {
"b": [
" set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
]
}
}
} |
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1511,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
BLumia
reviewed
Jul 17, 2026
| bool DPlatformWindowInterface::enableBlurWindow() const | ||
| { | ||
| #ifdef Q_OS_WIN | ||
| return m_enableBlurWindow; |
Comment on lines
+19
to
+25
| #if defined(DTK_STATIC_LIB) | ||
| # define LIBDTKGUISHARED_EXPORT | ||
| #elif defined(LIBDTKGUI_LIBRARY) | ||
| # define LIBDTKGUISHARED_EXPORT Q_DECL_EXPORT | ||
| #else | ||
| # define LIBDTKGUISHARED_EXPORT Q_DECL_IMPORT | ||
| #endif |
Member
There was a problem hiding this comment.
我觉得不block本PR，不过这个是不是后续用CMake的generate_export_header好一点？
- Conditionally compile DConfig code behind D_DISABLE_DCONFIG macro with DTK_DCONFIG_PTR abstraction for MSYS2/Windows builds - Remove duplicate QDBus, QDir, QLockFile, QDirIterator, and DPathBuf includes in dguiapplicationhelper.cpp
Contributor
|
Warning
详情 {
"export": {
"dtkgui.cmake": {
"b": [
" set(CMAKE_SHARED_LINKER_FLAGS \"${CMAKE_SHARED_LINKER_FLAGS} -Wl,--export-all-symbols\")"
]
}
}
} |
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1511,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix build error on Windows