-
Notifications
You must be signed in to change notification settings - Fork 68
fix: build error on Windows #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kt286
wants to merge
3
commits into
linuxdeepin:master
Choose a base branch
from
kt286:fix/build_on_msys2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| // SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd. | ||
| // SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd. | ||
| // | ||
| // SPDX-License-Identifier: LGPL-3.0-or-later | ||
|
|
||
|
|
@@ -28,18 +28,30 @@ void DPlatformWindowInterface::setEnabled(bool enabled) | |
|
|
||
| bool DPlatformWindowInterface::isEnabled() const | ||
| { | ||
| #ifdef Q_OS_WIN | ||
| return true; | ||
| #else | ||
| return false; | ||
| #endif | ||
| } | ||
|
|
||
| bool DPlatformWindowInterface::isEnabledNoTitlebar() const | ||
| { | ||
| #ifdef Q_OS_WIN | ||
| return true; | ||
| #else | ||
| return {}; | ||
| #endif | ||
| } | ||
|
|
||
| bool DPlatformWindowInterface::setEnabledNoTitlebar(bool enable) | ||
| { | ||
| Q_UNUSED(enable) | ||
| #ifdef Q_OS_WIN | ||
| return true; | ||
| #else | ||
| return {}; | ||
| #endif | ||
| } | ||
|
|
||
| void DPlatformWindowInterface::setDisableWindowOverrideCursor(bool disable) | ||
|
|
@@ -184,12 +196,45 @@ void DPlatformWindowInterface::setEnableSystemMove(bool enableSystemMove) | |
|
|
||
| bool DPlatformWindowInterface::enableBlurWindow() const | ||
| { | ||
| #ifdef Q_OS_WIN | ||
| return m_enableBlurWindow; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 咦?windows下支持这个的吗?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 其实我也不太懂 反正能编译通过就是了 |
||
| #else | ||
| return {}; | ||
| #endif | ||
| } | ||
|
|
||
| void DPlatformWindowInterface::setEnableBlurWindow(bool enableBlurWindow) | ||
| { | ||
| #ifdef Q_OS_WIN | ||
| if (m_enableBlurWindow == enableBlurWindow) | ||
| return; | ||
| m_enableBlurWindow = enableBlurWindow; | ||
| if (m_platformHandle) { | ||
| Q_EMIT m_platformHandle->enableBlurWindowChanged(); | ||
| } | ||
| #else | ||
| Q_UNUSED(enableBlurWindow) | ||
| #endif | ||
| } | ||
|
|
||
| bool DPlatformWindowInterface::setWindowBlurArea(const QVector<DPlatformHandle::WMBlurArea> &area) | ||
| { | ||
| Q_UNUSED(area) | ||
| #ifdef Q_OS_WIN | ||
| return true; | ||
| #else | ||
| return false; | ||
| #endif | ||
| } | ||
|
|
||
| bool DPlatformWindowInterface::setWindowBlurArea(const QList<QPainterPath> &paths) | ||
| { | ||
| Q_UNUSED(paths) | ||
| #ifdef Q_OS_WIN | ||
| return true; | ||
| #else | ||
| return false; | ||
| #endif | ||
| } | ||
|
|
||
| DGUI_END_NAMESPACE | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得不block本PR,不过这个是不是后续用CMake的generate_export_header好一点?