feat(krisp): adding krisp viva plugin for voice isolation - #1904
Merged
Conversation
🦋 Changeset detectedLatest commit: 4f3db4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1egoman
approved these changes
Jun 29, 2026
1egoman
left a comment
1egoman
left a comment
Contributor
There was a problem hiding this comment.
Generally makes sense to me!
Comment on lines
+299
to
+311
| // Emit exactly as many samples as we received this call. Before the first | ||
| // full chunk is ready the deficit is zero-padded; samples in and out stay | ||
| // balanced over time, so there is no drift. | ||
| const n = frame.samplesPerChannel; | ||
| let out: Int16Array; | ||
| if (this.outBuf.length >= n) { | ||
| out = this.outBuf.slice(0, n); | ||
| this.outBuf = this.outBuf.slice(n); | ||
| } else { | ||
| out = new Int16Array(n); | ||
| out.set(this.outBuf, n - this.outBuf.length); | ||
| this.outBuf = new Int16Array(0); | ||
| } |
Contributor
There was a problem hiding this comment.
Relevant comment from associated agents pull request: livekit/agents#5914 (comment). I think this could be vulnerable to the same problem.
1egoman
reviewed
Jun 29, 2026
lukasIO
marked this pull request as ready for review
July 6, 2026 13:54
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1egoman
approved these changes
Jul 6, 2026
u9g
approved these changes
Jul 10, 2026
u9g
left a comment
u9g
left a comment
Contributor
There was a problem hiding this comment.
I reviewed the code and had claude review the code and found no problems with it. I ran this locally and could talk back and forth with the agent.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lukasIO
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a plugin for the Krisp Viva SDK, allowing for direct LK cloud usage and the custom license wrapper, mirroring livekit/agents#5914
Changes Made
Pre-Review Checklist
Testing
restaurant_agent.tsandrealtime_agent.tswork properly (for major changes)Additional Notes
Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.