Add LiveKit cloud auth to krisp viva plugin - #5914
Merged
Merged
Conversation
1egoman
reviewed
Jun 8, 2026
1egoman
left a comment
1egoman
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good to me, once this is no longer draft I can take another look and probably approve.
8 tasks
1egoman
approved these changes
Jun 29, 2026
1egoman
left a comment
1egoman
left a comment
Contributor
There was a problem hiding this comment.
Generally makes sense to me!
Comment on lines
+97
to
+111
| # To use a Krisp license key + .kef model file instead, supply an explicit | ||
| # auth provider: | ||
| # | ||
| # processor = krisp.KrispVivaFilterFrameProcessor( | ||
| # auth_provider=krisp.auth.krisp_license( | ||
| # # Both default to env vars KRISP_VIVA_SDK_LICENSE_KEY and | ||
| # # KRISP_VIVA_FILTER_MODEL_PATH if omitted. | ||
| # license_key="...", | ||
| # model_path="/path/to/model.kef", | ||
| # ), | ||
| # noise_suppression_level=100, | ||
| # frame_duration_ms=10, | ||
| # sample_rate=16000, | ||
| # ) | ||
|
|
Contributor
There was a problem hiding this comment.
nitpick: Maybe add a note here that this path is required for use with a non hosted SFU?
Comment on lines
-40
to
-45
| # Note: krisp-audio is a required runtime dependency but not available on public PyPI. | ||
| # It must be obtained and installed separately from Krisp. | ||
| # Install with: pip install krisp-audio (from Krisp's private repository or distribution) | ||
| # The plugin handles missing krisp-audio gracefully with ImportError. | ||
| # This dependency is declared here for documentation purposes only. | ||
| # Since it's not on PyPI, it cannot be listed in dependencies or optional-dependencies. |
Contributor
There was a problem hiding this comment.
thought: Is it still worth keeping this caveat around, since it's still true for the local SFU krisp plugin path?
Contributor
Author
There was a problem hiding this comment.
this should become clear from the README and the krisp-audio package isn't required anymore as it will work ootb with cloud usage
…risp.py Co-authored-by: Ryan Gaus <ryan.gaus@livekit.io>
lukasIO
marked this pull request as ready for review
July 10, 2026 07:00
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
theomonnom
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplified default usage for cloud users now looks like