Skip to content

Avoid recomputing getenv("FPC_EXPONENT_USAGE)" #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Archaversine wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid recomputing getenv("FPC_EXPONENT_USAGE)" #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f38dc71
Avoid calling getenv multiple times
Archaversine Feb 26, 2026
6ab0120
Logical bug
Archaversine Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Instrumentation_cpu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,11 @@ CPUFPInstrumentation::CPUFPInstrumentation(Module *M)
assert(prog_args && "Invalid table!");
prog_args->setLinkage(GlobalValue::LinkageTypes::LinkOnceODRLinkage);

GlobalVariable *exponent_usage_flag = nullptr;
exponent_usage_flag = mod->getGlobalVariable("_FPC_EXPONENT_USAGE_FLAG", true);
assert(exponent_usage_flag && "Invalid table!");
exponent_usage_flag->setLinkage(GlobalValue::LinkageTypes::LinkOnceODRLinkage);

GlobalVariable *fpc_lock = nullptr;
fpc_lock = mod->getGlobalVariable("fpc_lock", true);
if (fpc_lock)
Expand Down
13 changes: 9 additions & 4 deletions src/Runtime_cpu.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ pthread_mutex_t fpc_lock;
int _FPC_PROG_INPUTS;
char **_FPC_PROG_ARGS;

/** Exponent usage flag **/
int _FPC_EXPONENT_USAGE_FLAG;

/*----------------------------------------------------------------------------*/
/* Initialize */
/*----------------------------------------------------------------------------*/
Expand All @@ -62,13 +65,15 @@ void _FPC_INIT_HASH_TABLE_()
void _FPC_INIT_FPCHECKER()
{
_FPC_PROG_INPUTS = 0;
_FPC_EXPONENT_USAGE_FLAG = 0;
_FPC_INIT_HASH_TABLE_();
}

void _FPC_INIT_ARGS_FPCHECKER(int argc, char **argv)
{
_FPC_PROG_INPUTS = argc;
_FPC_PROG_ARGS = argv;
_FPC_EXPONENT_USAGE_FLAG = getenv("FPC_EXPONENT_USAGE") != NULL;
_FPC_INIT_HASH_TABLE_();
}

Expand Down Expand Up @@ -620,7 +625,7 @@ void _FPC_FP32_CHECK_(
item.latent_infinity_neg = (uint64_t)_FPC_FP32_IS_LATENT_INFINITY_NEG(x);
item.latent_underflow = (uint64_t)_FPC_FP32_IS_LATENT_SUBNORMAL(x);

if (getenv("FPC_EXPONENT_USAGE") != NULL)
if (_FPC_EXPONENT_USAGE_FLAG)
{
// Set exponent usage to zero
for (int i = 0; i < FPC_HISTOGRAM_LEN; ++i)
Expand All @@ -635,7 +640,7 @@ void _FPC_FP32_CHECK_(
// If FPC_EXPONENT_USAGE is not defined (default), we only save items in the table
// if an event ocurred. If FPC_EXPONENT_USAGE is defined, we save all items
// (since we want to profile all instructions).
if (getenv("FPC_EXPONENT_USAGE") == NULL)
if (!_FPC_EXPONENT_USAGE_FLAG)
{
if (!_FPC_EVENT_OCURRED(&item))
return;
Expand Down Expand Up @@ -686,7 +691,7 @@ void _FPC_FP64_CHECK_(
item.latent_infinity_neg = (uint64_t)_FPC_FP64_IS_LATENT_INFINITY_NEG(x);
item.latent_underflow = (uint64_t)_FPC_FP64_IS_LATENT_SUBNORMAL(x);

if (getenv("FPC_EXPONENT_USAGE") != NULL)
if (_FPC_EXPONENT_USAGE_FLAG)
{
// Set exponent usage to zero
for (int i = 0; i < FPC_HISTOGRAM_LEN; ++i)
Expand All @@ -701,7 +706,7 @@ void _FPC_FP64_CHECK_(
// If FPC_EXPONENT_USAGE is not defined (default), we only save items in the table
// if an event ocurred. If FPC_EXPONENT_USAGE is defined, we save all items
// (since we want to profile all instructions).
if (getenv("FPC_EXPONENT_USAGE") == NULL)
if (!_FPC_EXPONENT_USAGE_FLAG)
{
if (!_FPC_EVENT_OCURRED(&item))
return;
Expand Down