Include property value in the error message#389
Merged
raymondfeng merged 2 commits intoJan 14, 2015
Conversation
bajtos
force-pushed
the
feature/include-value-in-validation-error-message
branch
from
January 12, 2015 14:03
17ed691 to
9cd74dc
Compare
This was referenced Jan 12, 2015
bajtos
force-pushed
the
feature/include-value-in-validation-error-message
branch
from
January 12, 2015 16:09
e6a5767 to
2df900f
Compare
added 2 commits
January 12, 2015 17:12
When building a list of errors for `ValidationError.message`, include the values of invalid properties too. In order to keep the message reasonably short, the values are truncated at approx 32 characters.
Return the raw object data when running on Node v0.11.14+ That way all `inspect` options are always preserved. When running on older version: - Honour the depth argument passed to the custom `inspect` function. - Disable color output, becase there is now way how to detect whether colors were enabled or disabled by the top-level caller.
bajtos
force-pushed
the
feature/include-value-in-validation-error-message
branch
from
January 12, 2015 16:12
2df900f to
e4fc387
Compare
Contributor
|
Awesome! I'm just happy that I'll have the values present for troubleshooting. Thanks for your work! |
Member
Author
|
@raymondfeng ping |
Member
Author
|
@slnode test please |
raymondfeng
added a commit
that referenced
this pull request
Jan 14, 2015
…dation-error-message Include property value in the error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building a list of errors for
ValidationError.message, includethe values of invalid properties too.
In order to keep the message reasonably short, the values are truncated
at approx 32 characters.
See the unit-tests for examples of error messages.
Supersedes #368.
A part of strongloop/strong-arc#562
/to @raymondfeng @bitmage please review
/cc @fabien @ritch FYI